Re: [PATCH 2/2] spi: add driver for STM32 SPI controller

2017-06-22 Thread Amelie DELAUNAY
Hi Mark, Thanks for your review. On 06/21/2017 05:13 PM, Mark Brown wrote: On Wed, Jun 21, 2017 at 04:32:06PM +0200, Amelie Delaunay wrote: A few minor stylistic things but overall this looks really nice, please send followup patches fixing these style things. + /* Determine the first

Re: [PATCH 2/2] spi: add driver for STM32 SPI controller

2017-06-21 Thread Mark Brown
On Wed, Jun 21, 2017 at 04:32:06PM +0200, Amelie Delaunay wrote: A few minor stylistic things but overall this looks really nice, please send followup patches fixing these style things. > + /* Determine the first power of 2 greater than or equal to div */ > + mbrdiv = (div & (div - 1)) ?

[PATCH 2/2] spi: add driver for STM32 SPI controller

2017-06-21 Thread Amelie Delaunay
The STM32 Serial Peripheral Interface (SPI) can be used to communicate with external devices while using the specific synchronous protocol. It supports a half-duplex, full-duplex and simplex synchronous, serial communication with external devices with 4-bit to 16/32-bit per word. It has two 8x/16x