Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-17 Thread Ivan T. Ivanov
Hi, On Mon, 2015-03-09 at 11:53 -0700, Stephen Boyd wrote: > On 03/09/15 01:20, Ivan T. Ivanov wrote: > > Hi Stephen, > > > > > On Mar 6, 2015, at 8:34 PM, Stephen Boyd wrote: > > > On 03/06/15 07:26, Ivan T. Ivanov wrote: > > > > Ensure that driver is owner of the GPIO's used for CS signals.

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-17 Thread Ivan T. Ivanov
Hi, On Mon, 2015-03-09 at 11:53 -0700, Stephen Boyd wrote: On 03/09/15 01:20, Ivan T. Ivanov wrote: Hi Stephen, On Mar 6, 2015, at 8:34 PM, Stephen Boyd sb...@codeaurora.org wrote: On 03/06/15 07:26, Ivan T. Ivanov wrote: Ensure that driver is owner of the GPIO's used for CS

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Mark Brown
On Tue, Mar 10, 2015 at 02:53:17PM +0200, Ivan T. Ivanov wrote: > > On Tue, 2015-03-10 at 11:06 +, Mark Brown wrote: > > I'm sorry but I can't parse the above. What does "they could issue > > setup method" mean and why is it a problem? > Client drivers could execute spi_setup() in probe(),

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Ivan T. Ivanov
On Tue, 2015-03-10 at 11:06 +, Mark Brown wrote: > On Tue, Mar 10, 2015 at 10:10:56AM +0200, Ivan T. Ivanov wrote: > > On Mon, 2015-03-09 at 18:28 +, Mark Brown wrote: > > > > > About the API usage, point taken. GPIO requesting part is more important > > > > in this case. pinctrl core

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Mark Brown
On Tue, Mar 10, 2015 at 10:10:56AM +0200, Ivan T. Ivanov wrote: > On Mon, 2015-03-09 at 18:28 +, Mark Brown wrote: > > > About the API usage, point taken. GPIO requesting part is more important > > > in this case. pinctrl core did not request pins and wrong DT configuration > > > could lead

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Ivan T. Ivanov
Hi, On Mon, 2015-03-09 at 11:53 -0700, Stephen Boyd wrote: > On 03/09/15 01:20, Ivan T. Ivanov wrote: > > Hi Stephen, > > > > > On Mar 6, 2015, at 8:34 PM, Stephen Boyd wrote: > > > On 03/06/15 07:26, Ivan T. Ivanov wrote: > > > > Ensure that driver is owner of the GPIO's used for CS signals.

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Ivan T. Ivanov
On Mon, 2015-03-09 at 18:28 +, Mark Brown wrote: > On Mon, Mar 09, 2015 at 10:23:35AM +0200, Ivan T. Ivanov wrote: > > Hi, > > Don't reply off list unless there's a good reason... Sorry, it was not intentional. Wrong button. > > > > Any new GPIO users should really be using the gpiod API,

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Mark Brown
On Tue, Mar 10, 2015 at 10:10:56AM +0200, Ivan T. Ivanov wrote: On Mon, 2015-03-09 at 18:28 +, Mark Brown wrote: About the API usage, point taken. GPIO requesting part is more important in this case. pinctrl core did not request pins and wrong DT configuration could lead to

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Ivan T. Ivanov
On Tue, 2015-03-10 at 11:06 +, Mark Brown wrote: On Tue, Mar 10, 2015 at 10:10:56AM +0200, Ivan T. Ivanov wrote: On Mon, 2015-03-09 at 18:28 +, Mark Brown wrote: About the API usage, point taken. GPIO requesting part is more important in this case. pinctrl core did not

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Mark Brown
On Tue, Mar 10, 2015 at 02:53:17PM +0200, Ivan T. Ivanov wrote: On Tue, 2015-03-10 at 11:06 +, Mark Brown wrote: I'm sorry but I can't parse the above. What does they could issue setup method mean and why is it a problem? Client drivers could execute spi_setup() in probe(), so we

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Ivan T. Ivanov
Hi, On Mon, 2015-03-09 at 11:53 -0700, Stephen Boyd wrote: On 03/09/15 01:20, Ivan T. Ivanov wrote: Hi Stephen, On Mar 6, 2015, at 8:34 PM, Stephen Boyd sb...@codeaurora.org wrote: On 03/06/15 07:26, Ivan T. Ivanov wrote: Ensure that driver is owner of the GPIO's used for CS

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-10 Thread Ivan T. Ivanov
On Mon, 2015-03-09 at 18:28 +, Mark Brown wrote: On Mon, Mar 09, 2015 at 10:23:35AM +0200, Ivan T. Ivanov wrote: Hi, Don't reply off list unless there's a good reason... Sorry, it was not intentional. Wrong button. Any new GPIO users should really be using the gpiod API, however

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-09 Thread Stephen Boyd
On 03/09/15 01:20, Ivan T. Ivanov wrote: > Hi Stephen, > >> On Mar 6, 2015, at 8:34 PM, Stephen Boyd wrote: >> On 03/06/15 07:26, Ivan T. Ivanov wrote: >>> Ensure that driver is owner of the GPIO's used for CS signals. >> Why? What happens if we don’t? > We can have wrong DT configuration, which

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-09 Thread Ivan T. Ivanov
Hi Stephen, > On Mar 6, 2015, at 8:34 PM, Stephen Boyd wrote: > On 03/06/15 07:26, Ivan T. Ivanov wrote: > > Ensure that driver is owner of the GPIO's used for CS signals. > Why? What happens if we don’t? We can have wrong DT configuration, which could reconfigure GPIO’s without any warning or

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-09 Thread Stephen Boyd
On 03/09/15 01:20, Ivan T. Ivanov wrote: Hi Stephen, On Mar 6, 2015, at 8:34 PM, Stephen Boyd sb...@codeaurora.org wrote: On 03/06/15 07:26, Ivan T. Ivanov wrote: Ensure that driver is owner of the GPIO's used for CS signals. Why? What happens if we don’t? We can have wrong DT

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-09 Thread Ivan T. Ivanov
Hi Stephen, On Mar 6, 2015, at 8:34 PM, Stephen Boyd sb...@codeaurora.org wrote: On 03/06/15 07:26, Ivan T. Ivanov wrote: Ensure that driver is owner of the GPIO's used for CS signals. Why? What happens if we don’t? We can have wrong DT configuration, which could reconfigure GPIO’s without

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-07 Thread Mark Brown
On Fri, Mar 06, 2015 at 05:26:18PM +0200, Ivan T. Ivanov wrote: > Ensure that driver is owner of the GPIO's used for CS signals. > + for (cs = 0; cs < master->num_chipselect; cs++) { > + cs_gpio = of_get_named_gpio(dev->of_node, "cs-gpios", cs); > + Any new GPIO users should

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-07 Thread Mark Brown
On Fri, Mar 06, 2015 at 05:26:18PM +0200, Ivan T. Ivanov wrote: Ensure that driver is owner of the GPIO's used for CS signals. + for (cs = 0; cs master-num_chipselect; cs++) { + cs_gpio = of_get_named_gpio(dev-of_node, cs-gpios, cs); + Any new GPIO users should really be

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-06 Thread Stephen Boyd
On 03/06/15 07:26, Ivan T. Ivanov wrote: > Ensure that driver is owner of the GPIO's used for CS signals. Why? What happens if we don't? > > Signed-off-by: Ivan T. Ivanov > --- > drivers/spi/spi-qup.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git

[PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-06 Thread Ivan T. Ivanov
Ensure that driver is owner of the GPIO's used for CS signals. Signed-off-by: Ivan T. Ivanov --- drivers/spi/spi-qup.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 2b2c359..a07ba46 100644 ---

[PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-06 Thread Ivan T. Ivanov
Ensure that driver is owner of the GPIO's used for CS signals. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/spi/spi-qup.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 2b2c359..a07ba46

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-06 Thread Stephen Boyd
On 03/06/15 07:26, Ivan T. Ivanov wrote: Ensure that driver is owner of the GPIO's used for CS signals. Why? What happens if we don't? Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/spi/spi-qup.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff