Re: [PATCH 2/2] staging: iio: adc: ad7192: Report error directly in ad7192_setup

2019-03-16 Thread Jonathan Cameron
On Sat, 16 Mar 2019 16:45:19 + Jonathan Cameron wrote: > On Fri, 15 Mar 2019 13:14:25 +0200 > Mircea Caprioru wrote: > > > This patch removes the goto out statement thus ensuring that an error is > > report as soon as it occurs. This gives more information and improves > > readability. >

Re: [PATCH 2/2] staging: iio: adc: ad7192: Report error directly in ad7192_setup

2019-03-16 Thread Jonathan Cameron
On Fri, 15 Mar 2019 13:14:25 +0200 Mircea Caprioru wrote: > This patch removes the goto out statement thus ensuring that an error is > report as soon as it occurs. This gives more information and improves > readability. No problem with the patch, but I'm not sure why it gives more information?

[PATCH 2/2] staging: iio: adc: ad7192: Report error directly in ad7192_setup

2019-03-15 Thread Mircea Caprioru
This patch removes the goto out statement thus ensuring that an error is report as soon as it occurs. This gives more information and improves readability. Signed-off-by: Mircea Caprioru --- drivers/staging/iio/adc/ad7192.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-)