Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-27 Thread Johannes Berg
Hi, So I removed those call-through place because private wext operations are a really bad idea and should just die. We don't want drivers to require specially patched hostapd versions to work right, like here. I suppose in staging you might want to work around that like here, but that really

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-27 Thread Johannes Berg
Hi, So I removed those call-through place because private wext operations are a really bad idea and should just die. We don't want drivers to require specially patched hostapd versions to work right, like here. I suppose in staging you might want to work around that like here, but that really

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread Ishraq Ibne Ashraf
Hi, What was broken was private/device specific IOCTL calls implemented by this driver. The standard IOCTL calls worked and the driver worked as it was in client mode. But in AP mode with hostapd (https://w1.fi/hostapd/) the rtl871xdrv driver of hostapd (which is required for using devices

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread Ishraq Ibne Ashraf
Hi, What was broken was private/device specific IOCTL calls implemented by this driver. The standard IOCTL calls worked and the driver worked as it was in client mode. But in AP mode with hostapd (https://w1.fi/hostapd/) the rtl871xdrv driver of hostapd (which is required for using devices

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread Ishraq Ibne Ashraf
Hi, What was broken was private/device specific IOCTL calls implemented by this driver. The standard IOCTL calls worked and the driver worked as it was in client mode. But in AP mode with hostapd (https://w1.fi/hostapd/) the rtl871xdrv driver of hostapd (which is required for using devices

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread Ishraq Ibne Ashraf
Hi, What was broken was private/device specific IOCTL calls implemented by this driver. The standard IOCTL calls worked and the driver worked as it was in client mode. But in AP mode with hostapd (https://w1.fi/hostapd/) the rtl871xdrv driver of hostapd (which is required for using devices

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread Dan Carpenter
Thanks for doing this. This needs to be folded in with the earlier patch you send and then resend it as a V2 patch. https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb I added Johannes to the CC list again because this is sort of his fault... To be honest,

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread Dan Carpenter
Thanks for doing this. This needs to be folded in with the earlier patch you send and then resend it as a V2 patch. https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb I added Johannes to the CC list again because this is sort of his fault... To be honest,

[PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread ishraq . i . ashraf
From: Ishraq Ibne Ashraf Apply changes suggested by Dan Carpenter --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 1052 1 file changed, 536 insertions(+), 516 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

[PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread ishraq . i . ashraf
From: Ishraq Ibne Ashraf Apply changes suggested by Dan Carpenter --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 1052 1 file changed, 536 insertions(+), 516 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c