Re: [PATCH 2/2] tasks: Add task_struct addr for lx-ps cmd

2020-08-18 Thread Ritesh Harjani 




On 8/18/20 11:10 AM, Jan Kiszka wrote:

On 18.08.20 06:04, Ritesh Harjani wrote:

task_struct addr in lx-ps cmd seems helpful


   TASK  PIDCOMM
0x82c2b8c0   0   swapper/0
0x888a0ba20040   1   systemd
0x888a0ba24040   2   kthreadd
0x888a0ba28040   3   rcu_gp

Signed-off-by: Ritesh Harjani 
---
  scripts/gdb/linux/tasks.py | 9 +
  1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
index 0301dc1e0138..17ec19e9b5bf 100644
--- a/scripts/gdb/linux/tasks.py
+++ b/scripts/gdb/linux/tasks.py
@@ -73,11 +73,12 @@ class LxPs(gdb.Command):
  super(LxPs, self).__init__("lx-ps", gdb.COMMAND_DATA)
  
  def invoke(self, arg, from_tty):

+gdb.write("{:>10} {:>12} {:>7}\n".format("TASK", "PID", "COMM"))
  for task in task_lists():
-gdb.write("{address} {pid} {comm}\n".format(
-address=task,
-pid=task["pid"],
-comm=task["comm"].string()))
+gdb.write("{} {:^5} {}\n".format(
+task.format_string().split()[0],
+task["pid"].format_string(),
+task["comm"].string()))
  
  
  LxPs()




This patch is confusing me. We already dump the task address. What the
patch changes is adding a header and some conversions of the values. Can
you elaborate?


You are right. Sorry for the confusion. I will update the commit msg (in
v2) to reflect that this patch adds the header and formats the spacing.
Without the patch we get it like this:-

0x82c2b8c0  0 swapper/0
0x888a0ba20040 1 systemd
0x888a0ba24040 2 kthreadd
0x888a0ba28040 3 rcu_gp

-ritesh

Re: [PATCH 2/2] tasks: Add task_struct addr for lx-ps cmd

2020-08-17 Thread Jan Kiszka 
On 18.08.20 06:04, Ritesh Harjani wrote:
> task_struct addr in lx-ps cmd seems helpful
> 
> 
>   TASK  PIDCOMM
> 0x82c2b8c0   0   swapper/0
> 0x888a0ba20040   1   systemd
> 0x888a0ba24040   2   kthreadd
> 0x888a0ba28040   3   rcu_gp
> 
> Signed-off-by: Ritesh Harjani 
> ---
>  scripts/gdb/linux/tasks.py | 9 +
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
> index 0301dc1e0138..17ec19e9b5bf 100644
> --- a/scripts/gdb/linux/tasks.py
> +++ b/scripts/gdb/linux/tasks.py
> @@ -73,11 +73,12 @@ class LxPs(gdb.Command):
>  super(LxPs, self).__init__("lx-ps", gdb.COMMAND_DATA)
>  
>  def invoke(self, arg, from_tty):
> +gdb.write("{:>10} {:>12} {:>7}\n".format("TASK", "PID", "COMM"))
>  for task in task_lists():
> -gdb.write("{address} {pid} {comm}\n".format(
> -address=task,
> -pid=task["pid"],
> -comm=task["comm"].string()))
> +gdb.write("{} {:^5} {}\n".format(
> +task.format_string().split()[0],
> +task["pid"].format_string(),
> +task["comm"].string()))
>  
>  
>  LxPs()
> 

This patch is confusing me. We already dump the task address. What the
patch changes is adding a header and some conversions of the values. Can
you elaborate?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

[PATCH 2/2] tasks: Add task_struct addr for lx-ps cmd

2020-08-17 Thread Ritesh Harjani 
task_struct addr in lx-ps cmd seems helpful


  TASK  PIDCOMM
0x82c2b8c0   0   swapper/0
0x888a0ba20040   1   systemd
0x888a0ba24040   2   kthreadd
0x888a0ba28040   3   rcu_gp

Signed-off-by: Ritesh Harjani 
---
 scripts/gdb/linux/tasks.py | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
index 0301dc1e0138..17ec19e9b5bf 100644
--- a/scripts/gdb/linux/tasks.py
+++ b/scripts/gdb/linux/tasks.py
@@ -73,11 +73,12 @@ class LxPs(gdb.Command):
 super(LxPs, self).__init__("lx-ps", gdb.COMMAND_DATA)
 
 def invoke(self, arg, from_tty):
+gdb.write("{:>10} {:>12} {:>7}\n".format("TASK", "PID", "COMM"))
 for task in task_lists():
-gdb.write("{address} {pid} {comm}\n".format(
-address=task,
-pid=task["pid"],
-comm=task["comm"].string()))
+gdb.write("{} {:^5} {}\n".format(
+task.format_string().split()[0],
+task["pid"].format_string(),
+task["comm"].string()))
 
 
 LxPs()
-- 
2.25.4