Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-12 Thread Thomas Gleixner
On Mon, 12 May 2014, Viresh Kumar wrote: > On 10 May 2014 16:31, Thomas Gleixner wrote: > > There is even a better way to do that: > > > > 1) Create a new callback set_state() which has an > >int return value. > > > > 2) Make the callsites do > > > >if (dev->set_state) { > > ret =

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-12 Thread Viresh Kumar
On 10 May 2014 16:31, Thomas Gleixner wrote: > There is even a better way to do that: > > 1) Create a new callback set_state() which has an >int return value. > > 2) Make the callsites do > >if (dev->set_state) { > ret = dev->set_state(); > handle_return_value(); >} else >

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-12 Thread Viresh Kumar
On 10 May 2014 16:31, Thomas Gleixner t...@linutronix.de wrote: There is even a better way to do that: 1) Create a new callback set_state() which has an int return value. 2) Make the callsites do if (dev-set_state) { ret = dev-set_state(); handle_return_value(); }

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-12 Thread Thomas Gleixner
On Mon, 12 May 2014, Viresh Kumar wrote: On 10 May 2014 16:31, Thomas Gleixner t...@linutronix.de wrote: There is even a better way to do that: 1) Create a new callback set_state() which has an int return value. 2) Make the callsites do if (dev-set_state) { ret =

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-11 Thread Viresh Kumar
Thanks for blasting me off, it might be very helpful going forward :) On 10 May 2014 01:39, Thomas Gleixner wrote: > On Fri, 9 May 2014, Viresh Kumar wrote: >> diff --git a/kernel/time/tick-oneshot.c b/kernel/time/tick-oneshot.c >> int tick_program_event(ktime_t expires, int force) >> { >>

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-11 Thread Viresh Kumar
Thanks for blasting me off, it might be very helpful going forward :) On 10 May 2014 01:39, Thomas Gleixner t...@linutronix.de wrote: On Fri, 9 May 2014, Viresh Kumar wrote: diff --git a/kernel/time/tick-oneshot.c b/kernel/time/tick-oneshot.c int tick_program_event(ktime_t expires, int

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-10 Thread Thomas Gleixner
On Fri, 9 May 2014, Thomas Gleixner wrote: > On Fri, 9 May 2014, Viresh Kumar wrote: > So the right thing to do this is: > > 1A) Change the prototype of the set_mode callback to return int and > fixup all users. Either add the missing default clause or remove > the existing BUG()/

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-10 Thread Thomas Gleixner
On Fri, 9 May 2014, Thomas Gleixner wrote: On Fri, 9 May 2014, Viresh Kumar wrote: So the right thing to do this is: 1A) Change the prototype of the set_mode callback to return int and fixup all users. Either add the missing default clause or remove the existing BUG()/

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-09 Thread Thomas Gleixner
On Fri, 9 May 2014, Viresh Kumar wrote: > When expires is set to KTIME_MAX in tick_program_event(), we are sure that > there > are no events enqueued for a very long time and so there is no point keeping > event device running. We will get interrupted without any work to do many a > times, for

[PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-09 Thread Viresh Kumar
When expires is set to KTIME_MAX in tick_program_event(), we are sure that there are no events enqueued for a very long time and so there is no point keeping event device running. We will get interrupted without any work to do many a times, for example when timer's counter overflows. So, its

[PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-09 Thread Viresh Kumar
When expires is set to KTIME_MAX in tick_program_event(), we are sure that there are no events enqueued for a very long time and so there is no point keeping event device running. We will get interrupted without any work to do many a times, for example when timer's counter overflows. So, its

Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

2014-05-09 Thread Thomas Gleixner
On Fri, 9 May 2014, Viresh Kumar wrote: When expires is set to KTIME_MAX in tick_program_event(), we are sure that there are no events enqueued for a very long time and so there is no point keeping event device running. We will get interrupted without any work to do many a times, for example