Re: [PATCH 2/2] tpm: replace kmalloc() + memcpy() with kmemdup()

2018-05-14 Thread Jarkko Sakkinen 
On Wed, May 09, 2018 at 09:12:37AM +0900, Ji-Hun Kim wrote:
> Use kmemdup rather than duplicating its implementation.
> 
> Signed-off-by: Ji-Hun Kim 

Reviewed-by: Jarkko Sakkinen 

/Jarkko

Re: [PATCH 2/2] tpm: replace kmalloc() + memcpy() with kmemdup()

2018-05-14 Thread Jarkko Sakkinen 
On Wed, May 09, 2018 at 09:12:37AM +0900, Ji-Hun Kim wrote:
> Use kmemdup rather than duplicating its implementation.
> 
> Signed-off-by: Ji-Hun Kim 

Reviewed-by: Jarkko Sakkinen 

/Jarkko

Re: [PATCH 2/2] tpm: replace kmalloc() + memcpy() with kmemdup()

2018-05-09 Thread James Morris 
On Wed, 9 May 2018, Ji-Hun Kim wrote:

> Use kmemdup rather than duplicating its implementation.
> 
> Signed-off-by: Ji-Hun Kim 


Reviewed-by: James Morris 


-- 
James Morris

Re: [PATCH 2/2] tpm: replace kmalloc() + memcpy() with kmemdup()

2018-05-09 Thread James Morris 
On Wed, 9 May 2018, Ji-Hun Kim wrote:

> Use kmemdup rather than duplicating its implementation.
> 
> Signed-off-by: Ji-Hun Kim 


Reviewed-by: James Morris 


-- 
James Morris

[PATCH 2/2] tpm: replace kmalloc() + memcpy() with kmemdup()

2018-05-08 Thread Ji-Hun Kim 
Use kmemdup rather than duplicating its implementation.

Signed-off-by: Ji-Hun Kim 
---
 drivers/char/tpm/eventlog/efi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/tpm/eventlog/efi.c b/drivers/char/tpm/eventlog/efi.c
index 68f1e7e..3e673ab 100644
--- a/drivers/char/tpm/eventlog/efi.c
+++ b/drivers/char/tpm/eventlog/efi.c
@@ -51,10 +51,9 @@ int tpm_read_log_efi(struct tpm_chip *chip)
}
 
/* malloc EventLog space */
-   log->bios_event_log = kmalloc(log_size, GFP_KERNEL);
+   log->bios_event_log = kmemdup(log_tbl->log, log_size, GFP_KERNEL);
if (!log->bios_event_log)
goto err_memunmap;
-   memcpy(log->bios_event_log, log_tbl->log, log_size);
log->bios_event_log_end = log->bios_event_log + log_size;
 
tpm_log_version = log_tbl->version;
-- 
1.9.1

[PATCH 2/2] tpm: replace kmalloc() + memcpy() with kmemdup()

2018-05-08 Thread Ji-Hun Kim 
Use kmemdup rather than duplicating its implementation.

Signed-off-by: Ji-Hun Kim 
---
 drivers/char/tpm/eventlog/efi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/tpm/eventlog/efi.c b/drivers/char/tpm/eventlog/efi.c
index 68f1e7e..3e673ab 100644
--- a/drivers/char/tpm/eventlog/efi.c
+++ b/drivers/char/tpm/eventlog/efi.c
@@ -51,10 +51,9 @@ int tpm_read_log_efi(struct tpm_chip *chip)
}
 
/* malloc EventLog space */
-   log->bios_event_log = kmalloc(log_size, GFP_KERNEL);
+   log->bios_event_log = kmemdup(log_tbl->log, log_size, GFP_KERNEL);
if (!log->bios_event_log)
goto err_memunmap;
-   memcpy(log->bios_event_log, log_tbl->log, log_size);
log->bios_event_log_end = log->bios_event_log + log_size;
 
tpm_log_version = log_tbl->version;
-- 
1.9.1