Re: [PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step

2012-11-26 Thread Suzuki K. Poulose
On 11/26/2012 10:31 PM, Oleg Nesterov wrote: On 11/26, Suzuki K. Poulose wrote: @@ -121,8 +125,11 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs) * to be executed. */ regs->nip = utask->vaddr + MAX_UINSN_BYTES; + regs->msr =

Re: [PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step

2012-11-26 Thread Oleg Nesterov
On 11/26, Suzuki K. Poulose wrote: > > @@ -121,8 +125,11 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, > struct pt_regs *regs) >* to be executed. >*/ > regs->nip = utask->vaddr + MAX_UINSN_BYTES; > + regs->msr = utask->autask.saved_msr; > +#ifdef

[PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step

2012-11-26 Thread Suzuki K. Poulose
From: Suzuki K. Poulose Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. Signed-off-by: Suzuki K. Poulose --- arch/powerpc/include/asm/uprobes.h |4

[PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step

2012-11-26 Thread Suzuki K. Poulose
From: Suzuki K. Poulose suz...@in.ibm.com Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. Signed-off-by: Suzuki K. Poulose suz...@in.ibm.com --- arch/powerpc/include/asm/uprobes.h

Re: [PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step

2012-11-26 Thread Oleg Nesterov
On 11/26, Suzuki K. Poulose wrote: @@ -121,8 +125,11 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs) * to be executed. */ regs-nip = utask-vaddr + MAX_UINSN_BYTES; + regs-msr = utask-autask.saved_msr; +#ifdef CONFIG_PPC_ADV_DEBUG_REGS

Re: [PATCH 2/2] uprobes/powerpc: Make use of generic routines to enable single step

2012-11-26 Thread Suzuki K. Poulose
On 11/26/2012 10:31 PM, Oleg Nesterov wrote: On 11/26, Suzuki K. Poulose wrote: @@ -121,8 +125,11 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs) * to be executed. */ regs-nip = utask-vaddr + MAX_UINSN_BYTES; + regs-msr =