Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-28 Thread Henrique de Moraes Holschuh
On Sat, 25 Jan 2014, Andi Kleen wrote: > On Sat, Jan 25, 2014 at 02:35:58PM -0200, Henrique de Moraes Holschuh wrote: > > On Fri, 24 Jan 2014, Andi Kleen wrote: > > > For testing purposes it can be useful to downgrade microcode. > > > Normally the driver only allows upgrading. > > > > The code is

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-28 Thread Henrique de Moraes Holschuh
On Sat, 25 Jan 2014, Andi Kleen wrote: On Sat, Jan 25, 2014 at 02:35:58PM -0200, Henrique de Moraes Holschuh wrote: On Fri, 24 Jan 2014, Andi Kleen wrote: For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. The code is not prepared

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-25 Thread Andi Kleen
On Sat, Jan 25, 2014 at 02:35:58PM -0200, Henrique de Moraes Holschuh wrote: > On Fri, 24 Jan 2014, Andi Kleen wrote: > > For testing purposes it can be useful to downgrade microcode. > > Normally the driver only allows upgrading. > > The code is not prepared to work correctly when downgrading is

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-25 Thread Henrique de Moraes Holschuh
On Fri, 24 Jan 2014, Andi Kleen wrote: > For testing purposes it can be useful to downgrade microcode. > Normally the driver only allows upgrading. The code is not prepared to work correctly when downgrading is allowed, in the presence of shadowed microcode. When a firmware request results in

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-25 Thread Henrique de Moraes Holschuh
On Fri, 24 Jan 2014, Andi Kleen wrote: For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. The code is not prepared to work correctly when downgrading is allowed, in the presence of shadowed microcode. When a firmware request results in more

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-25 Thread Andi Kleen
On Sat, Jan 25, 2014 at 02:35:58PM -0200, Henrique de Moraes Holschuh wrote: On Fri, 24 Jan 2014, Andi Kleen wrote: For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. The code is not prepared to work correctly when downgrading is

[PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-24 Thread Andi Kleen
From: Andi Kleen For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. Add a module_param (default off) that allows downgrading. Note the module_param can currently not be set for early ucode update, only for late. Signed-off-by: Andi Kleen

[PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2014-01-24 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. Add a module_param (default off) that allows downgrading. Note the module_param can currently not be set for early ucode update, only for late.

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-14 Thread Henrique de Moraes Holschuh
On Fri, 13 Dec 2013, Henrique de Moraes Holschuh wrote: > 2. This change has unintended side-effects that ought to be at least > documented: > > In "allow downgrade" mode, should you send a microcode pack with several > microcodes to the kernel, and more than one of them might apply to the >

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-14 Thread Henrique de Moraes Holschuh
On Fri, 13 Dec 2013, Henrique de Moraes Holschuh wrote: 2. This change has unintended side-effects that ought to be at least documented: In allow downgrade mode, should you send a microcode pack with several microcodes to the kernel, and more than one of them might apply to the running

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-13 Thread Henrique de Moraes Holschuh
On Fri, 06 Dec 2013, Andi Kleen wrote: > For testing purposes it can be useful to downgrade microcode. > Normally the driver only allows upgrading. ... > int > update_match_revision(struct microcode_header_intel *mc_header, int rev) > { > + if (allow_downgrade) > + return 1; >

Re: [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-13 Thread Henrique de Moraes Holschuh
On Fri, 06 Dec 2013, Andi Kleen wrote: For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. ... int update_match_revision(struct microcode_header_intel *mc_header, int rev) { + if (allow_downgrade) + return 1;

[PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-12 Thread Andi Kleen
From: Andi Kleen For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. Add a module_param (default off) that allows downgrading. Note the module_param can currently not be set for early ucode update, only for late. Signed-off-by: Andi Kleen

[PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-12 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. Add a module_param (default off) that allows downgrading. Note the module_param can currently not be set for early ucode update, only for late.

[PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-06 Thread Andi Kleen
From: Andi Kleen For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. Add a module_param (default off) that allows downgrading. Note the module_param can currently not be set for early ucode update, only for late. Signed-off-by: Andi Kleen

[PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode

2013-12-06 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com For testing purposes it can be useful to downgrade microcode. Normally the driver only allows upgrading. Add a module_param (default off) that allows downgrading. Note the module_param can currently not be set for early ucode update, only for late.