Re: [PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

2015-04-09 Thread Alexander Kuleshov
Hello Peter, 2015-04-08 17:32 GMT+06:00 Peter Hurley : >> + >> +void setup_early_serial_console() { > > If you put this function in kernel/early_printk.c, then > setup_early_printk() can remain file scope. > Yes, right. will fix it. > > The WARN is still required here because the

Re: [PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

2015-04-09 Thread Alexander Kuleshov
Hello Peter, 2015-04-08 17:32 GMT+06:00 Peter Hurley pe...@hurleysoftware.com: + +void setup_early_serial_console() { If you put this function in kernel/early_printk.c, then setup_early_printk() can remain file scope. Yes, right. will fix it. The WARN is still required here because the

Re: [PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

2015-04-08 Thread Peter Hurley
Hi Alexander, On 04/08/2015 05:31 AM, Alexander Kuleshov wrote: > As setup_early_printk passed to the early_param, it will be usable only after > 'parse_early_param' function will be called from the 'setup_arch'. So we have > earlyprintk during early boot and decompression. Next point after >

[PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

2015-04-08 Thread Alexander Kuleshov
As setup_early_printk passed to the early_param, it will be usable only after 'parse_early_param' function will be called from the 'setup_arch'. So we have earlyprintk during early boot and decompression. Next point after decompression of the kernel where we can use early_printk is after call of

Re: [PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

2015-04-08 Thread Peter Hurley
Hi Alexander, On 04/08/2015 05:31 AM, Alexander Kuleshov wrote: As setup_early_printk passed to the early_param, it will be usable only after 'parse_early_param' function will be called from the 'setup_arch'. So we have earlyprintk during early boot and decompression. Next point after

[PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

2015-04-08 Thread Alexander Kuleshov
As setup_early_printk passed to the early_param, it will be usable only after 'parse_early_param' function will be called from the 'setup_arch'. So we have earlyprintk during early boot and decompression. Next point after decompression of the kernel where we can use early_printk is after call of