Re: [PATCH 2/2] x86: Replace this_cpu_sp0 with current_top_of_stack and fix it on x86_32

2015-03-26 Thread Andy Lutomirski
On Mar 26, 2015 6:32 AM, "Boris Ostrovsky" wrote: > > On 03/06/2015 08:50 PM, Andy Lutomirski wrote: >> >> I broke 32-bit kernels. The implementation of sp0 was correct as >> far as I can tell, but sp0 was much weirder on x86_32 than I >> realized. It has the following issues: >> >> - Init's s

Re: [PATCH 2/2] x86: Replace this_cpu_sp0 with current_top_of_stack and fix it on x86_32

2015-03-26 Thread Boris Ostrovsky
On 03/06/2015 08:50 PM, Andy Lutomirski wrote: I broke 32-bit kernels. The implementation of sp0 was correct as far as I can tell, but sp0 was much weirder on x86_32 than I realized. It has the following issues: - Init's sp0 is inconsistent with everything else's: non-init tasks are offs

[PATCH 2/2] x86: Replace this_cpu_sp0 with current_top_of_stack and fix it on x86_32

2015-03-06 Thread Andy Lutomirski
I broke 32-bit kernels. The implementation of sp0 was correct as far as I can tell, but sp0 was much weirder on x86_32 than I realized. It has the following issues: - Init's sp0 is inconsistent with everything else's: non-init tasks are offset by 8 bytes. (I have no idea why, and the commen