Re: [PATCH 2/2] x86: set a dependency on macros.S

[Ingo Molnar]

* Nadav Amit  wrote:

> Changes in macros.S should trigger the recompilation of all C files, as
> the macros might need to affect their compilation.
> 
> Signed-off-by: Nadav Amit 
> ---
>  scripts/Makefile.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index d2213b041408..ffe3e1a01210 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -312,13 +312,13 @@ cmd_undef_syms = echo
>  endif
>  
>  # Built-in and composite module parts
> -$(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
> +$(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) 
> $(ASM_MACRO_FILE:.s=.S) FORCE
>   $(call cmd,force_checksrc)
>   $(call if_changed_rule,cc_o_c)
>  
>  # Single-part modules are special since we need to mark them in $(MODVERDIR)
>  
> -$(single-used-m): $(obj)/%.o: $(src)/%.c $(recordmcount_source) 
> $(objtool_dep) FORCE
> +$(single-used-m): $(obj)/%.o: $(src)/%.c $(recordmcount_source) 
> $(objtool_dep) $(ASM_MACRO_FILE:.s=.S) FORCE
>   $(call cmd,force_checksrc)
>   $(call if_changed_rule,cc_o_c)
>   @{ echo $(@:.o=.ko); echo $@; \

Acked-by: Ingo Molnar 

Thanks,

Ingo

[PATCH 2/2] x86: set a dependency on macros.S

[Nadav Amit]

Changes in macros.S should trigger the recompilation of all C files, as
the macros might need to affect their compilation.

Signed-off-by: Nadav Amit 
---
 scripts/Makefile.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index d2213b041408..ffe3e1a01210 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -312,13 +312,13 @@ cmd_undef_syms = echo
 endif
 
 # Built-in and composite module parts
-$(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
+$(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) 
$(ASM_MACRO_FILE:.s=.S) FORCE
$(call cmd,force_checksrc)
$(call if_changed_rule,cc_o_c)
 
 # Single-part modules are special since we need to mark them in $(MODVERDIR)
 
-$(single-used-m): $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) 
FORCE
+$(single-used-m): $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) 
$(ASM_MACRO_FILE:.s=.S) FORCE
$(call cmd,force_checksrc)
$(call if_changed_rule,cc_o_c)
@{ echo $(@:.o=.ko); echo $@; \
-- 
2.17.1