Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-25 Thread Nathan Zimmer
On Tue, Jul 24, 2012 at 09:38:21PM -0700, Hugh Dickins wrote: > > I'm glad Andrew took out the stable Cc: Actually I did that. I have a habit of thinking about performance issues as bugs and that is not always the case. > Please, what's wrong with the patch below, to replace the current > two

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-25 Thread KOSAKI Motohiro
> Please, what's wrong with the patch below, to replace the current > two or three? I don't have real NUMA myself: does it work? > If it doesn't work, can you see why not? It works. It doesn't match my preference. but I don't want block your way. this area is maintained you. please go ahead. at

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-25 Thread Nathan Zimmer
On Tue, Jul 24, 2012 at 09:38:21PM -0700, Hugh Dickins wrote: I'm glad Andrew took out the stable Cc: Actually I did that. I have a habit of thinking about performance issues as bugs and that is not always the case. Please, what's wrong with the patch below, to replace the current two or

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-25 Thread KOSAKI Motohiro
Please, what's wrong with the patch below, to replace the current two or three? I don't have real NUMA myself: does it work? If it doesn't work, can you see why not? It works. It doesn't match my preference. but I don't want block your way. this area is maintained you. please go ahead. at

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-24 Thread Hugh Dickins
Nathan, Kosaki-san, I have, at long last, reached the point of looking at this patchset. And I'm puzzled as to why it has grown more complicated than what you first sent out. I've read through the various threads, and some of the changes I like. I'm glad Andrew took out the stable Cc: obviously

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-24 Thread Hugh Dickins
Nathan, Kosaki-san, I have, at long last, reached the point of looking at this patchset. And I'm puzzled as to why it has grown more complicated than what you first sent out. I've read through the various threads, and some of the changes I like. I'm glad Andrew took out the stable Cc: obviously

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-23 Thread Nathan Zimmer
Yes I had failed to notice that. I'll send a fix shortly. On 07/23/2012 05:58 AM, Dan Carpenter wrote: On Mon, Jul 09, 2012 at 09:46:39AM -0500, Nathan Zimmer wrote: +static unsigned long shmem_interleave(struct vm_area_struct *vma, + unsigned long addr)

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-23 Thread Dan Carpenter
On Mon, Jul 09, 2012 at 09:46:39AM -0500, Nathan Zimmer wrote: > +static unsigned long shmem_interleave(struct vm_area_struct *vma, > + unsigned long addr) > +{ > + unsigned long offset; > + > + /* Use the vm_files prefered node as the initial offset. */

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-23 Thread Dan Carpenter
On Mon, Jul 09, 2012 at 09:46:39AM -0500, Nathan Zimmer wrote: +static unsigned long shmem_interleave(struct vm_area_struct *vma, + unsigned long addr) +{ + unsigned long offset; + + /* Use the vm_files prefered node as the initial offset. */ +

Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-23 Thread Nathan Zimmer
Yes I had failed to notice that. I'll send a fix shortly. On 07/23/2012 05:58 AM, Dan Carpenter wrote: On Mon, Jul 09, 2012 at 09:46:39AM -0500, Nathan Zimmer wrote: +static unsigned long shmem_interleave(struct vm_area_struct *vma, + unsigned long addr)

[PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-09 Thread Nathan Zimmer
The tmpfs superblock grants an offset for each inode as they are created. Each inode then uses that offset to provide a preferred first node for its interleave in the newly provided shmem_interleave. Cc: Christoph Lameter Cc: Nick Piggin Cc: Hugh Dickins Cc: Lee Schermerhorn Cc: KOSAKI

[PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

2012-07-09 Thread Nathan Zimmer
The tmpfs superblock grants an offset for each inode as they are created. Each inode then uses that offset to provide a preferred first node for its interleave in the newly provided shmem_interleave. Cc: Christoph Lameter c...@linux.com Cc: Nick Piggin npig...@gmail.com Cc: Hugh Dickins