subject:"\[PATCH 2\/3\] ARM\: mxs\: dt\: Add Crystalfontz CFA\-10056 device tree"

Re: [PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

2013-06-26 Thread Maxime Ripard

Hi Alexandre,

On Wed, Jun 26, 2013 at 04:52:26PM +0200, Alexandre Belloni wrote:
> From: Brian Lilly 
> 
> The CFA-10056 is a breakout board for the CFA-10036, and is
> basically a CFA-10037, with ai 4.3" screen.
   ^ typo

> Signed-off-by: Brian Lilly 
> Signed-off-by: Alexandre Belloni 
> ---
>  arch/arm/boot/dts/Makefile   |   1 +
>  arch/arm/boot/dts/imx28-cfa10056.dts | 200 
> +++
>  2 files changed, 201 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 225d939..d494f37 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
>   imx28-cfa10037.dtb \
>   imx28-cfa10049.dtb \
>   imx28-cfa10055.dtb \
> + imx28-cfa10056.dtb \
>   imx28-cfa10057.dtb \
>   imx28-evk.dtb \
>   imx28-m28evk.dtb \
> diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts 
> b/arch/arm/boot/dts/imx28-cfa10056.dts
> new file mode 100644
> index 000..47b5016
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx28-cfa10056.dts
> @@ -0,0 +1,200 @@
> +/*
> + * Copyright 2012 Free Electrons
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/*
> + * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
> + * need to include the CFA-10036 DTS.
> + */
> +/include/ "imx28-cfa10036.dts"
> +
> +/ {
> + model = "Crystalfontz CFA-10056 Board";
> + compatible = "crystalfontz,cfa10056", "crystalfontz,cfa10036", 
> "fsl,imx28";
> +
> + apb@8000 {
> + apbh@8000 {
> + pinctrl@80018000 {
> + pinctrl-names = "default", "default";
> + pinctrl-1 = <_pins_cfa10056
> + _pins_cfa10056_pullup>;
> +
> + hog_pins_cfa10056: hog-10056@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x0073 /* 
> MX28_PAD_GPMI_D7__GPIO_0_7 */
> + 0x2153 /* 
> MX28_PAD_SSP2_D5__GPIO_2_21 */
> + 0x3053 /* 
> MX28_PAD_AUART1_TX__GPIO_3_5 */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
> +
> + hog_pins_cfa10056_pullup: hog-10056-pullup@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x2133 /* 
> MX28_PAD_SSP2_D3__GPIO_2_19 */
> + 0x3183 /* 
> MX28_PAD_I2C0_SCL__GPIO_3_24 */
> + 0x3193 /* 
> MX28_PAD_I2C0_SDA__GPIO_3_25 */
> + 0x31a3 /* 
> MX28_PAD_SAIF_SDATA0__GPIO_3_26 */
> + 0x31e3 /* 
> MX28_PAD_LCD_RESET__GPIO_3_30 */
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <1>;
> + };

These pins don't seem used in your DT. Are you sure you need them?

> + spi2_pins_cfa10056: spi2-cfa10056@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x2103 /* 
> MX28_PAD_SSP2_SCK__GPIO_2_16 */
> + 0x2113 /* 
> MX28_PAD_SSP2_CMD__GPIO_2_17 */
> + 0x2123 /* 
> MX28_PAD_SSP2_D0__GPIO_2_18 */
> + >;
> + fsl,drive-strength = <1>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <1>;
> + };
> +
> + spi3_pins_cfa10056: spi3-cfa10056@0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x0183 /* 
> MX28_PAD_GPMI_RDN__GPIO_0_24 */
> + 0x01c3 /* 
> MX28_PAD_GPMI_RESETN__GPIO_0_28 */
> +

[PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

2013-06-26 Thread Alexandre Belloni

From: Brian Lilly 

The CFA-10056 is a breakout board for the CFA-10036, and is
basically a CFA-10037, with ai 4.3" screen.

Signed-off-by: Brian Lilly 
Signed-off-by: Alexandre Belloni 
---
 arch/arm/boot/dts/Makefile   |   1 +
 arch/arm/boot/dts/imx28-cfa10056.dts | 200 +++
 2 files changed, 201 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 225d939..d494f37 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-cfa10037.dtb \
imx28-cfa10049.dtb \
imx28-cfa10055.dtb \
+   imx28-cfa10056.dtb \
imx28-cfa10057.dtb \
imx28-evk.dtb \
imx28-m28evk.dtb \
diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts 
b/arch/arm/boot/dts/imx28-cfa10056.dts
new file mode 100644
index 000..47b5016
--- /dev/null
+++ b/arch/arm/boot/dts/imx28-cfa10056.dts
@@ -0,0 +1,200 @@
+/*
+ * Copyright 2012 Free Electrons
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/*
+ * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
+ * need to include the CFA-10036 DTS.
+ */
+/include/ "imx28-cfa10036.dts"
+
+/ {
+   model = "Crystalfontz CFA-10056 Board";
+   compatible = "crystalfontz,cfa10056", "crystalfontz,cfa10036", 
"fsl,imx28";
+
+   apb@8000 {
+   apbh@8000 {
+   pinctrl@80018000 {
+   pinctrl-names = "default", "default";
+   pinctrl-1 = <_pins_cfa10056
+   _pins_cfa10056_pullup>;
+
+   hog_pins_cfa10056: hog-10056@0 {
+   reg = <0>;
+   fsl,pinmux-ids = <
+   0x0073 /* 
MX28_PAD_GPMI_D7__GPIO_0_7 */
+   0x2153 /* 
MX28_PAD_SSP2_D5__GPIO_2_21 */
+   0x3053 /* 
MX28_PAD_AUART1_TX__GPIO_3_5 */
+   >;
+   fsl,drive-strength = <0>;
+   fsl,voltage = <1>;
+   fsl,pull-up = <0>;
+   };
+
+   hog_pins_cfa10056_pullup: hog-10056-pullup@0 {
+   reg = <0>;
+   fsl,pinmux-ids = <
+   0x2133 /* 
MX28_PAD_SSP2_D3__GPIO_2_19 */
+   0x3183 /* 
MX28_PAD_I2C0_SCL__GPIO_3_24 */
+   0x3193 /* 
MX28_PAD_I2C0_SDA__GPIO_3_25 */
+   0x31a3 /* 
MX28_PAD_SAIF_SDATA0__GPIO_3_26 */
+   0x31e3 /* 
MX28_PAD_LCD_RESET__GPIO_3_30 */
+   >;
+   fsl,drive-strength = <0>;
+   fsl,voltage = <1>;
+   fsl,pull-up = <1>;
+   };
+
+   spi2_pins_cfa10056: spi2-cfa10056@0 {
+   reg = <0>;
+   fsl,pinmux-ids = <
+   0x2103 /* 
MX28_PAD_SSP2_SCK__GPIO_2_16 */
+   0x2113 /* 
MX28_PAD_SSP2_CMD__GPIO_2_17 */
+   0x2123 /* 
MX28_PAD_SSP2_D0__GPIO_2_18 */
+   >;
+   fsl,drive-strength = <1>;
+   fsl,voltage = <1>;
+   fsl,pull-up = <1>;
+   };
+
+   spi3_pins_cfa10056: spi3-cfa10056@0 {
+   reg = <0>;
+   fsl,pinmux-ids = <
+   0x0183 /* 
MX28_PAD_GPMI_RDN__GPIO_0_24 */
+   0x01c3 /* 
MX28_PAD_GPMI_RESETN__GPIO_0_28 */
+   0x0113 /* 
MX28_PAD_GPMI_CE1N__GPIO_0_17 */
+   0x01a3 /* 
MX28_PAD_GPMI_ALE__GPIO_0_26 */
+   0x01b3 /* 
MX28_PAD_GPMI_CLE__GPIO_0_27 */
+   >;
+

[PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

2013-06-26 Thread Alexandre Belloni

From: Brian Lilly br...@crystalfontz.com

The CFA-10056 is a breakout board for the CFA-10036, and is
basically a CFA-10037, with ai 4.3 screen.

Signed-off-by: Brian Lilly br...@crystalfontz.com
Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com
---
 arch/arm/boot/dts/Makefile   |   1 +
 arch/arm/boot/dts/imx28-cfa10056.dts | 200 +++
 2 files changed, 201 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 225d939..d494f37 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx28-cfa10037.dtb \
imx28-cfa10049.dtb \
imx28-cfa10055.dtb \
+   imx28-cfa10056.dtb \
imx28-cfa10057.dtb \
imx28-evk.dtb \
imx28-m28evk.dtb \
diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts 
b/arch/arm/boot/dts/imx28-cfa10056.dts
new file mode 100644
index 000..47b5016
--- /dev/null
+++ b/arch/arm/boot/dts/imx28-cfa10056.dts
@@ -0,0 +1,200 @@
+/*
+ * Copyright 2012 Free Electrons
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/*
+ * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
+ * need to include the CFA-10036 DTS.
+ */
+/include/ imx28-cfa10036.dts
+
+/ {
+   model = Crystalfontz CFA-10056 Board;
+   compatible = crystalfontz,cfa10056, crystalfontz,cfa10036, 
fsl,imx28;
+
+   apb@8000 {
+   apbh@8000 {
+   pinctrl@80018000 {
+   pinctrl-names = default, default;
+   pinctrl-1 = hog_pins_cfa10056
+   hog_pins_cfa10056_pullup;
+
+   hog_pins_cfa10056: hog-10056@0 {
+   reg = 0;
+   fsl,pinmux-ids = 
+   0x0073 /* 
MX28_PAD_GPMI_D7__GPIO_0_7 */
+   0x2153 /* 
MX28_PAD_SSP2_D5__GPIO_2_21 */
+   0x3053 /* 
MX28_PAD_AUART1_TX__GPIO_3_5 */
+   ;
+   fsl,drive-strength = 0;
+   fsl,voltage = 1;
+   fsl,pull-up = 0;
+   };
+
+   hog_pins_cfa10056_pullup: hog-10056-pullup@0 {
+   reg = 0;
+   fsl,pinmux-ids = 
+   0x2133 /* 
MX28_PAD_SSP2_D3__GPIO_2_19 */
+   0x3183 /* 
MX28_PAD_I2C0_SCL__GPIO_3_24 */
+   0x3193 /* 
MX28_PAD_I2C0_SDA__GPIO_3_25 */
+   0x31a3 /* 
MX28_PAD_SAIF_SDATA0__GPIO_3_26 */
+   0x31e3 /* 
MX28_PAD_LCD_RESET__GPIO_3_30 */
+   ;
+   fsl,drive-strength = 0;
+   fsl,voltage = 1;
+   fsl,pull-up = 1;
+   };
+
+   spi2_pins_cfa10056: spi2-cfa10056@0 {
+   reg = 0;
+   fsl,pinmux-ids = 
+   0x2103 /* 
MX28_PAD_SSP2_SCK__GPIO_2_16 */
+   0x2113 /* 
MX28_PAD_SSP2_CMD__GPIO_2_17 */
+   0x2123 /* 
MX28_PAD_SSP2_D0__GPIO_2_18 */
+   ;
+   fsl,drive-strength = 1;
+   fsl,voltage = 1;
+   fsl,pull-up = 1;
+   };
+
+   spi3_pins_cfa10056: spi3-cfa10056@0 {
+   reg = 0;
+   fsl,pinmux-ids = 
+   0x0183 /* 
MX28_PAD_GPMI_RDN__GPIO_0_24 */
+   0x01c3 /* 
MX28_PAD_GPMI_RESETN__GPIO_0_28 */
+   0x0113 /* 
MX28_PAD_GPMI_CE1N__GPIO_0_17 */
+   0x01a3 /* 
MX28_PAD_GPMI_ALE__GPIO_0_26 */
+   0x01b3 /* 
MX28_PAD_GPMI_CLE__GPIO_0_27 */
+

Re: [PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

2013-06-26 Thread Maxime Ripard

Hi Alexandre,

On Wed, Jun 26, 2013 at 04:52:26PM +0200, Alexandre Belloni wrote:
 From: Brian Lilly br...@crystalfontz.com
 
 The CFA-10056 is a breakout board for the CFA-10036, and is
 basically a CFA-10037, with ai 4.3 screen.
   ^ typo

 Signed-off-by: Brian Lilly br...@crystalfontz.com
 Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com
 ---
  arch/arm/boot/dts/Makefile   |   1 +
  arch/arm/boot/dts/imx28-cfa10056.dts | 200 
 +++
  2 files changed, 201 insertions(+)
  create mode 100644 arch/arm/boot/dts/imx28-cfa10056.dts
 
 diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
 index 225d939..d494f37 100644
 --- a/arch/arm/boot/dts/Makefile
 +++ b/arch/arm/boot/dts/Makefile
 @@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
   imx28-cfa10037.dtb \
   imx28-cfa10049.dtb \
   imx28-cfa10055.dtb \
 + imx28-cfa10056.dtb \
   imx28-cfa10057.dtb \
   imx28-evk.dtb \
   imx28-m28evk.dtb \
 diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts 
 b/arch/arm/boot/dts/imx28-cfa10056.dts
 new file mode 100644
 index 000..47b5016
 --- /dev/null
 +++ b/arch/arm/boot/dts/imx28-cfa10056.dts
 @@ -0,0 +1,200 @@
 +/*
 + * Copyright 2012 Free Electrons
 + *
 + * The code contained herein is licensed under the GNU General Public
 + * License. You may obtain a copy of the GNU General Public License
 + * Version 2 or later at the following locations:
 + *
 + * http://www.opensource.org/licenses/gpl-license.html
 + * http://www.gnu.org/copyleft/gpl.html
 + */
 +
 +/*
 + * The CFA-10056 is an expansion board for the CFA-10036 module, thus we
 + * need to include the CFA-10036 DTS.
 + */
 +/include/ imx28-cfa10036.dts
 +
 +/ {
 + model = Crystalfontz CFA-10056 Board;
 + compatible = crystalfontz,cfa10056, crystalfontz,cfa10036, 
 fsl,imx28;
 +
 + apb@8000 {
 + apbh@8000 {
 + pinctrl@80018000 {
 + pinctrl-names = default, default;
 + pinctrl-1 = hog_pins_cfa10056
 + hog_pins_cfa10056_pullup;
 +
 + hog_pins_cfa10056: hog-10056@0 {
 + reg = 0;
 + fsl,pinmux-ids = 
 + 0x0073 /* 
 MX28_PAD_GPMI_D7__GPIO_0_7 */
 + 0x2153 /* 
 MX28_PAD_SSP2_D5__GPIO_2_21 */
 + 0x3053 /* 
 MX28_PAD_AUART1_TX__GPIO_3_5 */
 + ;
 + fsl,drive-strength = 0;
 + fsl,voltage = 1;
 + fsl,pull-up = 0;
 + };
 +
 + hog_pins_cfa10056_pullup: hog-10056-pullup@0 {
 + reg = 0;
 + fsl,pinmux-ids = 
 + 0x2133 /* 
 MX28_PAD_SSP2_D3__GPIO_2_19 */
 + 0x3183 /* 
 MX28_PAD_I2C0_SCL__GPIO_3_24 */
 + 0x3193 /* 
 MX28_PAD_I2C0_SDA__GPIO_3_25 */
 + 0x31a3 /* 
 MX28_PAD_SAIF_SDATA0__GPIO_3_26 */
 + 0x31e3 /* 
 MX28_PAD_LCD_RESET__GPIO_3_30 */
 + ;
 + fsl,drive-strength = 0;
 + fsl,voltage = 1;
 + fsl,pull-up = 1;
 + };

These pins don't seem used in your DT. Are you sure you need them?

 + spi2_pins_cfa10056: spi2-cfa10056@0 {
 + reg = 0;
 + fsl,pinmux-ids = 
 + 0x2103 /* 
 MX28_PAD_SSP2_SCK__GPIO_2_16 */
 + 0x2113 /* 
 MX28_PAD_SSP2_CMD__GPIO_2_17 */
 + 0x2123 /* 
 MX28_PAD_SSP2_D0__GPIO_2_18 */
 + ;
 + fsl,drive-strength = 1;
 + fsl,voltage = 1;
 + fsl,pull-up = 1;
 + };
 +
 + spi3_pins_cfa10056: spi3-cfa10056@0 {
 + reg = 0;
 + fsl,pinmux-ids = 
 + 0x0183 /* 
 MX28_PAD_GPMI_RDN__GPIO_0_24 */
 + 0x01c3 /* 
 MX28_PAD_GPMI_RESETN__GPIO_0_28 */
 + 0x0113 /* 
 MX28_PAD_GPMI_CE1N__GPIO_0_17 */

Re: [PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

[PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

[PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

Re: [PATCH 2/3] ARM: mxs: dt: Add Crystalfontz CFA-10056 device tree

4 matches

Site Navigation

Mail list logo

Footer information