Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Chen Guangyu-B42378
Thank you, sir. And sorry for taking your time. Sent by Android device. Timur Tabi wrote: Chen Guangyu-B42378 wrote: > Without dual fifo support, handware underrun would occasionally > occur and then two audio channels would physically swap. This could > be easily reproduced in low bus

Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Timur Tabi
Chen Guangyu-B42378 wrote: Without dual fifo support, handware underrun would occasionally occur and then two audio channels would physically swap. This could be easily reproduced in low bus frequency situation, while it would be better if we enable dual fifo. Ok. ACK. -- To unsubscribe from

Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Chen Guangyu-B42378
Without dual fifo support, handware underrun would occasionally occur and then two audio channels would physically swap. This could be easily reproduced in low bus frequency situation, while it would be better if we enable dual fifo. Sent by Android device. Timur Tabi wrote: Nicolin Chen

Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Timur Tabi
Nicolin Chen wrote: By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. Have you measured any real performance gain with this patch? I considered adding dual-FIFO support when I originally wrote

[PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. [ Passed compile-test with mpc85xx_defconfig ] Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 24 +++- 1 file

[PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. [ Passed compile-test with mpc85xx_defconfig ] Signed-off-by: Nicolin Chen b42...@freescale.com --- sound/soc/fsl/fsl_ssi.c | 24

Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Timur Tabi
Nicolin Chen wrote: By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. Have you measured any real performance gain with this patch? I considered adding dual-FIFO support when I originally wrote

Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Chen Guangyu-B42378
Without dual fifo support, handware underrun would occasionally occur and then two audio channels would physically swap. This could be easily reproduced in low bus frequency situation, while it would be better if we enable dual fifo. Sent by Android device. Timur Tabi ti...@tabi.org wrote:

Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Timur Tabi
Chen Guangyu-B42378 wrote: Without dual fifo support, handware underrun would occasionally occur and then two audio channels would physically swap. This could be easily reproduced in low bus frequency situation, while it would be better if we enable dual fifo. Ok. ACK. -- To unsubscribe from

Re: [PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Chen Guangyu-B42378
Thank you, sir. And sorry for taking your time. Sent by Android device. Timur Tabi ti...@tabi.org wrote: Chen Guangyu-B42378 wrote: Without dual fifo support, handware underrun would occasionally occur and then two audio channels would physically swap. This could be easily reproduced in