Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-29 Thread Kenneth Westfield
On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: > This patch fixes lpass-platform driver which was broken in v4.9-rc1. > lpass_pcm_data data structure holds information specific to stream. > Holding a single private pointer to it in global lpass_data > will not work, because

Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-29 Thread Kenneth Westfield
On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: > This patch fixes lpass-platform driver which was broken in v4.9-rc1. > lpass_pcm_data data structure holds information specific to stream. > Holding a single private pointer to it in global lpass_data > will not work, because

Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-28 Thread Srinivas Kandagatla
On 28/10/16 19:26, Mark Brown wrote: On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: This patch fixes lpass-platform driver which was broken in v4.9-rc1. lpass_pcm_data data structure holds information specific to stream. Holding a single private pointer to it in global

Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-28 Thread Srinivas Kandagatla
On 28/10/16 19:26, Mark Brown wrote: On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: This patch fixes lpass-platform driver which was broken in v4.9-rc1. lpass_pcm_data data structure holds information specific to stream. Holding a single private pointer to it in global

Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-28 Thread Mark Brown
On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: > This patch fixes lpass-platform driver which was broken in v4.9-rc1. > lpass_pcm_data data structure holds information specific to stream. > Holding a single private pointer to it in global lpass_data > will not work, because

Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-28 Thread Mark Brown
On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: > This patch fixes lpass-platform driver which was broken in v4.9-rc1. > lpass_pcm_data data structure holds information specific to stream. > Holding a single private pointer to it in global lpass_data > will not work, because

[PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-28 Thread Srinivas Kandagatla
This patch fixes lpass-platform driver which was broken in v4.9-rc1. lpass_pcm_data data structure holds information specific to stream. Holding a single private pointer to it in global lpass_data will not work, because it would be overwritten by for each pcm instance. This code was breaking

[PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage

2016-10-28 Thread Srinivas Kandagatla
This patch fixes lpass-platform driver which was broken in v4.9-rc1. lpass_pcm_data data structure holds information specific to stream. Holding a single private pointer to it in global lpass_data will not work, because it would be overwritten by for each pcm instance. This code was breaking