Re: [PATCH 2/3] ASoC: rt5677: Add ACPI device probing

2014-10-07 Thread Mark Brown
On Fri, Oct 03, 2014 at 02:37:25PM -0700, Ben Zhang wrote: > +#ifdef CONFIG_ACPI > + .acpi_match_table = ACPI_PTR(rt5677_acpi_id), > +#endif Why do you need this ifdef - surely the whole point of ACPI_PTR() is to avoid needing it? signature.asc Description: Digital signature

Re: [PATCH 2/3] ASoC: rt5677: Add ACPI device probing

2014-10-07 Thread Mark Brown
On Fri, Oct 03, 2014 at 02:37:25PM -0700, Ben Zhang wrote: +#ifdef CONFIG_ACPI + .acpi_match_table = ACPI_PTR(rt5677_acpi_id), +#endif Why do you need this ifdef - surely the whole point of ACPI_PTR() is to avoid needing it? signature.asc Description: Digital signature

[PATCH 2/3] ASoC: rt5677: Add ACPI device probing

2014-10-03 Thread Ben Zhang
The rt5677 codec driver looks for ACPI device ID "RT5677CE", which is specified in coreboot. Signed-off-by: Ben Zhang Reviewed-on: https://chromium-review.googlesource.com/207622 Reviewed-by: Dylan Reid Reviewed-by: AndyX C Huang --- sound/soc/codecs/rt5677.c | 12 1 file

[PATCH 2/3] ASoC: rt5677: Add ACPI device probing

2014-10-03 Thread Ben Zhang
The rt5677 codec driver looks for ACPI device ID RT5677CE, which is specified in coreboot. Signed-off-by: Ben Zhang be...@chromium.org Reviewed-on: https://chromium-review.googlesource.com/207622 Reviewed-by: Dylan Reid dgr...@chromium.org Reviewed-by: AndyX C Huang andyx.c.hu...@intel.com ---