Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-15 Thread Mark Brown
On Fri, Dec 12, 2014 at 03:48:51PM -0800, Ben Zhang wrote: > On Fri, Dec 12, 2014 at 5:27 AM, Mark Brown wrote: > > On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: > > Why is this being specified as some magic number rather than using the > > voltage (or at least providing defines for

Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-15 Thread Mark Brown
On Fri, Dec 12, 2014 at 03:48:51PM -0800, Ben Zhang wrote: On Fri, Dec 12, 2014 at 5:27 AM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: Why is this being specified as some magic number rather than using the voltage (or at least providing

Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-12 Thread Ben Zhang
On Fri, Dec 12, 2014 at 5:27 AM, Mark Brown wrote: > On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: > >> The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V > > The changelog says "platform config" but this is adding DT binding. > >> +- realtek,micbias1 >> + Select

Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-12 Thread Mark Brown
On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: > The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V The changelog says "platform config" but this is adding DT binding. > +- realtek,micbias1 > + Select 0/1/2/3 to set MICBIAS1 voltage to 1.476V/2.970V/1.242V/2.475V

Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-12 Thread Mark Brown
On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V The changelog says platform config but this is adding DT binding. +- realtek,micbias1 + Select 0/1/2/3 to set MICBIAS1 voltage to 1.476V/2.970V/1.242V/2.475V +

Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-12 Thread Ben Zhang
On Fri, Dec 12, 2014 at 5:27 AM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote: The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V The changelog says platform config but this is adding DT binding. +- realtek,micbias1 +

[PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-10 Thread Ben Zhang
The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V Signed-off-by: Ben Zhang --- Documentation/devicetree/bindings/sound/rt5677.txt | 4 include/sound/rt5677.h | 9 + sound/soc/codecs/rt5677.c | 6 ++ 3

[PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage

2014-12-10 Thread Ben Zhang
The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V Signed-off-by: Ben Zhang be...@chromium.org --- Documentation/devicetree/bindings/sound/rt5677.txt | 4 include/sound/rt5677.h | 9 + sound/soc/codecs/rt5677.c