Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-22 Thread Mark Brown
On Fri, May 22, 2015 at 12:25:05AM -0700, Brian Norris wrote: > On Fri, May 22, 2015 at 12:17:27AM -0700, Brian Norris wrote: > > Admittedly, as he's using an out-of-tree driver, I'm not > > sure I know exactly what failure modes he is hitting yet. > Sorry, I realized I misread here. He's using

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-22 Thread Brian Norris
(trimming CC a little this time, though it's still a bit large) On Fri, May 22, 2015 at 12:17:27AM -0700, Brian Norris wrote: > Admittedly, as he's using an out-of-tree driver, I'm not > sure I know exactly what failure modes he is hitting yet. Sorry, I realized I misread here. He's using

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-22 Thread Brian Norris
On Thu, May 21, 2015 at 11:28:02AM +0100, Mark Brown wrote: > On Thu, May 21, 2015 at 10:39:13AM +0200, Michal Suchanek wrote: > > On 21 May 2015 at 01:38, Brian Norris wrote: > > Why is this thread about SPI error handling CCed to quite so many > people? I can't really speak for the original

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-22 Thread Brian Norris
On Thu, May 21, 2015 at 11:28:02AM +0100, Mark Brown wrote: On Thu, May 21, 2015 at 10:39:13AM +0200, Michal Suchanek wrote: On 21 May 2015 at 01:38, Brian Norris computersforpe...@gmail.com wrote: Why is this thread about SPI error handling CCed to quite so many people? I can't really

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-22 Thread Brian Norris
(trimming CC a little this time, though it's still a bit large) On Fri, May 22, 2015 at 12:17:27AM -0700, Brian Norris wrote: Admittedly, as he's using an out-of-tree driver, I'm not sure I know exactly what failure modes he is hitting yet. Sorry, I realized I misread here. He's using

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-22 Thread Mark Brown
On Fri, May 22, 2015 at 12:25:05AM -0700, Brian Norris wrote: On Fri, May 22, 2015 at 12:17:27AM -0700, Brian Norris wrote: Admittedly, as he's using an out-of-tree driver, I'm not sure I know exactly what failure modes he is hitting yet. Sorry, I realized I misread here. He's using

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-21 Thread Mark Brown
On Thu, May 21, 2015 at 10:39:13AM +0200, Michal Suchanek wrote: > On 21 May 2015 at 01:38, Brian Norris wrote: Why is this thread about SPI error handling CCed to quite so many people? > >> Check the amount of data actually written by the driver. > > I'm not sure if we should just reactively

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-21 Thread Michal Suchanek
On 21 May 2015 at 01:38, Brian Norris wrote: > + linux-spi, Mark > > On Thu, Apr 30, 2015 at 03:38:50PM +0200, Michal Suchanek wrote: >> My SPI controller driver does not support DMA so writes are truncated to >> FIFO size. > > Which SPI master driver? I am using sunxi SPI driver. The dmaengine

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-21 Thread Michal Suchanek
On 21 May 2015 at 01:38, Brian Norris computersforpe...@gmail.com wrote: + linux-spi, Mark On Thu, Apr 30, 2015 at 03:38:50PM +0200, Michal Suchanek wrote: My SPI controller driver does not support DMA so writes are truncated to FIFO size. Which SPI master driver? I am using sunxi SPI

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-21 Thread Mark Brown
On Thu, May 21, 2015 at 10:39:13AM +0200, Michal Suchanek wrote: On 21 May 2015 at 01:38, Brian Norris computersforpe...@gmail.com wrote: Why is this thread about SPI error handling CCed to quite so many people? Check the amount of data actually written by the driver. I'm not sure if we

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-20 Thread Brian Norris
+ linux-spi, Mark On Thu, Apr 30, 2015 at 03:38:50PM +0200, Michal Suchanek wrote: > My SPI controller driver does not support DMA so writes are truncated to > FIFO size. Which SPI master driver? > Check the amount of data actually written by the driver. I'm not sure if we should just

Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.

2015-05-20 Thread Brian Norris
+ linux-spi, Mark On Thu, Apr 30, 2015 at 03:38:50PM +0200, Michal Suchanek wrote: My SPI controller driver does not support DMA so writes are truncated to FIFO size. Which SPI master driver? Check the amount of data actually written by the driver. I'm not sure if we should just reactively