Re: [PATCH 2/3] PCI: correctly detect ACPI PCI host bridge objects

2012-10-26 Thread Yinghai Lu
On Fri, Oct 26, 2012 at 2:10 AM, Bjorn Helgaas wrote: > On Thu, Oct 18, 2012 at 2:50 PM, Yinghai Lu wrote: >> >> +static const struct acpi_device_id root_device_ids[] = { >> + {"PNP0A03", 0}, >> + {"PNP0A08", 0}, > > Why do we need PNP0A08 here? > > Per the PCI Firmware Spec, sec

Re: [PATCH 2/3] PCI: correctly detect ACPI PCI host bridge objects

2012-10-26 Thread Bjorn Helgaas
On Thu, Oct 18, 2012 at 2:50 PM, Yinghai Lu wrote: > From: Jiang Liu > > The code in pci_root_hp.c depends on function acpi_is_root_bridge() > to check whether an ACPI object is a PCI host bridge or not. > If an ACPI device hasn't been created for the ACPI object yet, > function

Re: [PATCH 2/3] PCI: correctly detect ACPI PCI host bridge objects

2012-10-26 Thread Bjorn Helgaas
On Thu, Oct 18, 2012 at 2:50 PM, Yinghai Lu ying...@kernel.org wrote: From: Jiang Liu jiang@huawei.com The code in pci_root_hp.c depends on function acpi_is_root_bridge() to check whether an ACPI object is a PCI host bridge or not. If an ACPI device hasn't been created for the ACPI object

Re: [PATCH 2/3] PCI: correctly detect ACPI PCI host bridge objects

2012-10-26 Thread Yinghai Lu
On Fri, Oct 26, 2012 at 2:10 AM, Bjorn Helgaas bhelg...@google.com wrote: On Thu, Oct 18, 2012 at 2:50 PM, Yinghai Lu ying...@kernel.org wrote: +static const struct acpi_device_id root_device_ids[] = { + {PNP0A03, 0}, + {PNP0A08, 0}, Why do we need PNP0A08 here? Per the PCI

[PATCH 2/3] PCI: correctly detect ACPI PCI host bridge objects

2012-10-18 Thread Yinghai Lu
From: Jiang Liu The code in pci_root_hp.c depends on function acpi_is_root_bridge() to check whether an ACPI object is a PCI host bridge or not. If an ACPI device hasn't been created for the ACPI object yet, function acpi_is_root_bridge() will return false even if the object is a PCI host bridge

[PATCH 2/3] PCI: correctly detect ACPI PCI host bridge objects

2012-10-18 Thread Yinghai Lu
From: Jiang Liu jiang@huawei.com The code in pci_root_hp.c depends on function acpi_is_root_bridge() to check whether an ACPI object is a PCI host bridge or not. If an ACPI device hasn't been created for the ACPI object yet, function acpi_is_root_bridge() will return false even if the object