Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-05 Thread Zhenzhong Duan
On 2013-08-02 20:01, Konrad Rzeszutek Wilk wrote: Konrad, are you OK with this patch now? Yes, I wanted to make sure that the existing behavior under baremetal was not altered. And Duan had confirmed it was not - thought to be on a safe side it would be good to confirm this via testing just

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-05 Thread Zhenzhong Duan
On 2013-08-02 20:01, Konrad Rzeszutek Wilk wrote: Konrad, are you OK with this patch now? Yes, I wanted to make sure that the existing behavior under baremetal was not altered. And Duan had confirmed it was not - thought to be on a safe side it would be good to confirm this via testing just

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-02 Thread Konrad Rzeszutek Wilk
> >>Konrad, are you OK with this patch now? > >Yes, I wanted to make sure that the existing behavior under baremetal > >was not altered. > > > >And Duan had confirmed it was not - thought to be on a safe side it > >would be good to confirm this via testing just in case. > I had ever let our

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-02 Thread Zhenzhong Duan
On 2013-08-01 23:16, Konrad Rzeszutek Wilk wrote: On Wed, Jul 31, 2013 at 04:41:32PM -0600, Bjorn Helgaas wrote: On Tue, Jul 23, 2013 at 9:08 PM, Zhenzhong Duan wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-02 Thread Konrad Rzeszutek Wilk
Konrad, are you OK with this patch now? Yes, I wanted to make sure that the existing behavior under baremetal was not altered. And Duan had confirmed it was not - thought to be on a safe side it would be good to confirm this via testing just in case. I had ever let our customer test on

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-02 Thread Zhenzhong Duan
On 2013-08-01 23:16, Konrad Rzeszutek Wilk wrote: On Wed, Jul 31, 2013 at 04:41:32PM -0600, Bjorn Helgaas wrote: On Tue, Jul 23, 2013 at 9:08 PM, Zhenzhong Duan zhenzhong.d...@oracle.com wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-01 Thread Konrad Rzeszutek Wilk
On Wed, Jul 31, 2013 at 04:41:32PM -0600, Bjorn Helgaas wrote: > On Tue, Jul 23, 2013 at 9:08 PM, Zhenzhong Duan > wrote: > > xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask > > in dom0. It's better to do the same for default_restore_msi_irqs in > > baremetal. > > > >

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-08-01 Thread Konrad Rzeszutek Wilk
On Wed, Jul 31, 2013 at 04:41:32PM -0600, Bjorn Helgaas wrote: On Tue, Jul 23, 2013 at 9:08 PM, Zhenzhong Duan zhenzhong.d...@oracle.com wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for default_restore_msi_irqs in

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-31 Thread Bjorn Helgaas
On Tue, Jul 23, 2013 at 9:08 PM, Zhenzhong Duan wrote: > xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask > in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. > > Move restore of mask in default_restore_msi_irqs, this could avoid mask >

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-31 Thread Bjorn Helgaas
On Tue, Jul 23, 2013 at 9:08 PM, Zhenzhong Duan zhenzhong.d...@oracle.com wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. Move restore of mask in default_restore_msi_irqs, this

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-25 Thread Zhenzhong Duan
On 2013-07-25 20:25, Konrad Rzeszutek Wilk wrote: On Thu, Jul 25, 2013 at 02:52:00PM +0800, Zhenzhong Duan wrote: On 2013-07-24 21:46, Konrad Rzeszutek Wilk wrote: On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-25 Thread Konrad Rzeszutek Wilk
On Thu, Jul 25, 2013 at 02:52:00PM +0800, Zhenzhong Duan wrote: > > On 2013-07-24 21:46, Konrad Rzeszutek Wilk wrote: > >On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: > >>xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask > >>in dom0. It's better to do

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-25 Thread Zhenzhong Duan
On 2013-07-24 21:46, Konrad Rzeszutek Wilk wrote: On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. Move restore of mask in

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-25 Thread Zhenzhong Duan
On 2013-07-24 21:46, Konrad Rzeszutek Wilk wrote: On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. Move restore of mask in

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-25 Thread Konrad Rzeszutek Wilk
On Thu, Jul 25, 2013 at 02:52:00PM +0800, Zhenzhong Duan wrote: On 2013-07-24 21:46, Konrad Rzeszutek Wilk wrote: On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-25 Thread Zhenzhong Duan
On 2013-07-25 20:25, Konrad Rzeszutek Wilk wrote: On Thu, Jul 25, 2013 at 02:52:00PM +0800, Zhenzhong Duan wrote: On 2013-07-24 21:46, Konrad Rzeszutek Wilk wrote: On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-24 Thread Konrad Rzeszutek Wilk
On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: > xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask > in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. > > Move restore of mask in default_restore_msi_irqs, this could avoid mask

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-24 Thread Konrad Rzeszutek Wilk
On Wed, Jul 24, 2013 at 11:08:10AM +0800, Zhenzhong Duan wrote: xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. Move restore of mask in default_restore_msi_irqs, this could avoid mask

[PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-23 Thread Zhenzhong Duan
xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. Move restore of mask in default_restore_msi_irqs, this could avoid mask restored twice in dom0, once in hypercall, the other in kernel.

[PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-23 Thread Zhenzhong Duan
xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. Move restore of mask in default_restore_msi_irqs, this could avoid mask restored twice in dom0, once in hypercall, the other in kernel.