Re: [PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

2007-05-26 Thread Alan Cox
On Mon, 21 May 2007 22:06:36 -0700 Junio C Hamano <[EMAIL PROTECTED]> wrote: > This introduces a shared header file that defines the entries > for two dma blacklists in ide-dma.c and libata-core.c to make it > easier to keep them in sync. > > Signed-off-by: Junio C Hamano <[EMAIL PROTECTED]>

Re: [PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

2007-05-26 Thread Bill Davidsen
Junio C Hamano wrote: This introduces a shared header file that defines the entries for two dma blacklists in ide-dma.c and libata-core.c to make it easier to keep them in sync. Why wasn't this done this way in the first place? Out of tree development for libata or something? -- Bill

Re: [PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

2007-05-26 Thread Bill Davidsen
Junio C Hamano wrote: This introduces a shared header file that defines the entries for two dma blacklists in ide-dma.c and libata-core.c to make it easier to keep them in sync. Why wasn't this done this way in the first place? Out of tree development for libata or something? -- Bill

Re: [PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

2007-05-26 Thread Alan Cox
On Mon, 21 May 2007 22:06:36 -0700 Junio C Hamano [EMAIL PROTECTED] wrote: This introduces a shared header file that defines the entries for two dma blacklists in ide-dma.c and libata-core.c to make it easier to keep them in sync. Signed-off-by: Junio C Hamano [EMAIL PROTECTED] NAK This

[PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

2007-05-21 Thread Junio C Hamano
This introduces a shared header file that defines the entries for two dma blacklists in ide-dma.c and libata-core.c to make it easier to keep them in sync. Signed-off-by: Junio C Hamano <[EMAIL PROTECTED]> --- * Removes more lines than it adds. I am not proud of the DMA_BLACK_LIST macro in

[PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

2007-05-21 Thread Junio C Hamano
This introduces a shared header file that defines the entries for two dma blacklists in ide-dma.c and libata-core.c to make it easier to keep them in sync. Signed-off-by: Junio C Hamano [EMAIL PROTECTED] --- * Removes more lines than it adds. I am not proud of the DMA_BLACK_LIST macro in