Re: [PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y

[Luca Risolia]

It's okay, thanks.

Reviewed-by: Luca Risolia <[EMAIL PROTECTED]>
---

On Saturday 16 February 2008 17:12:26 Roel Kluin wrote:
> The patch below was not yet tested. If it's incorrect, please comment.
> ---
> Fix Unlikely(x) == y
>
> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
> ---
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
> b/drivers/media/video/sn9c102/sn9c102_core.c index c40ba3a..66313b1 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -528,7 +528,7 @@ sn9c102_find_sof_header(struct sn9c102_device* cam,
> void* mem, size_t len)
>
>   /* Search for the SOF marker (fixed part) in the header */
>   for (j = 0, b=cam->sof.bytesread; j+b < sizeof(marker); j++) {
> - if (unlikely(i+j) == len)
> + if (unlikely(i+j == len))
>   return NULL;
>   if (*(m+i+j) == marker[cam->sof.bytesread]) {
>   cam->sof.header[cam->sof.bytesread] = *(m+i+j);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y

[Roel Kluin]

The patch below was not yet tested. If it's incorrect, please comment.
---
Fix Unlikely(x) == y

Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/media/video/sn9c102/sn9c102_core.c 
b/drivers/media/video/sn9c102/sn9c102_core.c
index c40ba3a..66313b1 100644
--- a/drivers/media/video/sn9c102/sn9c102_core.c
+++ b/drivers/media/video/sn9c102/sn9c102_core.c
@@ -528,7 +528,7 @@ sn9c102_find_sof_header(struct sn9c102_device* cam, void* 
mem, size_t len)
 
/* Search for the SOF marker (fixed part) in the header */
for (j = 0, b=cam->sof.bytesread; j+b < sizeof(marker); j++) {
-   if (unlikely(i+j) == len)
+   if (unlikely(i+j == len))
return NULL;
if (*(m+i+j) == marker[cam->sof.bytesread]) {
cam->sof.header[cam->sof.bytesread] = *(m+i+j);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y

[Roel Kluin]

The patch below was not yet tested. If it's incorrect, please comment.
---
Fix Unlikely(x) == y

Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/media/video/sn9c102/sn9c102_core.c 
b/drivers/media/video/sn9c102/sn9c102_core.c
index c40ba3a..66313b1 100644
--- a/drivers/media/video/sn9c102/sn9c102_core.c
+++ b/drivers/media/video/sn9c102/sn9c102_core.c
@@ -528,7 +528,7 @@ sn9c102_find_sof_header(struct sn9c102_device* cam, void* 
mem, size_t len)
 
/* Search for the SOF marker (fixed part) in the header */
for (j = 0, b=cam-sof.bytesread; j+b  sizeof(marker); j++) {
-   if (unlikely(i+j) == len)
+   if (unlikely(i+j == len))
return NULL;
if (*(m+i+j) == marker[cam-sof.bytesread]) {
cam-sof.header[cam-sof.bytesread] = *(m+i+j);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y

[Luca Risolia]

It's okay, thanks.

Reviewed-by: Luca Risolia [EMAIL PROTECTED]
---

On Saturday 16 February 2008 17:12:26 Roel Kluin wrote:
 The patch below was not yet tested. If it's incorrect, please comment.
 ---
 Fix Unlikely(x) == y

 Signed-off-by: Roel Kluin [EMAIL PROTECTED]
 ---
 diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
 b/drivers/media/video/sn9c102/sn9c102_core.c index c40ba3a..66313b1 100644
 --- a/drivers/media/video/sn9c102/sn9c102_core.c
 +++ b/drivers/media/video/sn9c102/sn9c102_core.c
 @@ -528,7 +528,7 @@ sn9c102_find_sof_header(struct sn9c102_device* cam,
 void* mem, size_t len)

   /* Search for the SOF marker (fixed part) in the header */
   for (j = 0, b=cam-sof.bytesread; j+b  sizeof(marker); j++) {
 - if (unlikely(i+j) == len)
 + if (unlikely(i+j == len))
   return NULL;
   if (*(m+i+j) == marker[cam-sof.bytesread]) {
   cam-sof.header[cam-sof.bytesread] = *(m+i+j);


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/