Re: [PATCH 2/3] drm/vc4: Enable runtime PM.

2016-02-16 Thread Eric Anholt
Eric Anholt writes: > +#ifdef CONFIG_PM_SLEEP > +static int vc4_v3d_runtime_suspend(struct device *dev) > +{ > + struct vc4_v3d *v3d = dev_get_drvdata(dev); > + struct vc4_dev *vc4 = v3d->vc4; > + > + vc4_irq_uninstall(vc4->dev); > + > + return 0; > +} > + >

Re: [PATCH 2/3] drm/vc4: Enable runtime PM.

2016-02-16 Thread Eric Anholt
Eric Anholt writes: > +#ifdef CONFIG_PM_SLEEP > +static int vc4_v3d_runtime_suspend(struct device *dev) > +{ > + struct vc4_v3d *v3d = dev_get_drvdata(dev); > + struct vc4_dev *vc4 = v3d->vc4; > + > + vc4_irq_uninstall(vc4->dev); > + > + return 0; > +} > + > +static int

[PATCH 2/3] drm/vc4: Enable runtime PM.

2016-02-08 Thread Eric Anholt
This may actually get us a feature that the closed driver didn't have: turning off the GPU in between rendering jobs, while the V3D device is still opened by the client. There may be some tuning to be applied here to use autosuspend so that we don't bounce the device's power so much, but in

[PATCH 2/3] drm/vc4: Enable runtime PM.

2016-02-08 Thread Eric Anholt
This may actually get us a feature that the closed driver didn't have: turning off the GPU in between rendering jobs, while the V3D device is still opened by the client. There may be some tuning to be applied here to use autosuspend so that we don't bounce the device's power so much, but in