Re: [PATCH 2/3] kunit: tool: fix minor typing issue with None status

2020-12-04 Thread Daniel Latypov
On Thu, Dec 3, 2020 at 8:17 PM David Gow wrote: > > On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote: > > > > This seems good to me, but I have a few questions, particularly around > the description. > > > The code to handle aggregating statuses didn't check that the status > > actually got

Re: [PATCH 2/3] kunit: tool: fix minor typing issue with None status

2020-12-03 Thread David Gow
On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote: > This seems good to me, but I have a few questions, particularly around the description. > The code to handle aggregating statuses didn't check that the status > actually got set. I don't understand what you mean here. Does this refer to

[PATCH 2/3] kunit: tool: fix minor typing issue with None status

2020-12-03 Thread Daniel Latypov
The code to handle aggregating statuses didn't check that the status actually got set. Default the value to SUCCESS. This sorta follows the precedent in commit 3fc48259d525 ("kunit: Don't fail test suites if one of them is empty"). Also slightly simplify the code and add type annotations.