Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
On 20/08/2019 at 11:10, Andreas Schwab wrote: > External E-Mail > > > On Aug 13 2019, Paul Walmsley wrote: > >> Dave, Nicolas, >> >> On Mon, 22 Jul 2019, Yash Shah wrote: >> >>> On Fri, Jul 19, 2019 at 5:36 PM wrote: On 19/07/2019 at 13:10, Yash Shah wrote: > Update the compatibility string for SiFive FU540-C000 as per the new > string updated in the binding doc. > Reference: https://lkml.org/lkml/2019/7/17/200 Maybe referring to lore.kernel.org is better: https://lore.kernel.org/netdev/caj2_jofevzqat0yprg4hem4jrrqkb72fkseqj4p8p5ka-+r...@mail.gmail.com/ >>> >>> Sure. Will keep that in mind for future reference. >>> > Signed-off-by: Yash Shah Acked-by: Nicolas Ferre >>> >>> Thanks. >> >> Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier. >> If not, please let us know. > > This is still missing in v5.4-rc5, which means that networking is broken. Andreas, Paul, The patchwork state for the 2 first patches of this series is "Changes Requested". It's probably due to my advice of using lore.kernel.org (or something else). I'm perfectly fine in accepting the patches are they are today but can't change their patchwork state myself. We would need Dave or Jakub to take them. Dave, Jakub, All tags are collected in patchwork and all should be fine on DT (Rob) side as well. Please tell me if you're waiting some sign from me. Best regards, -- Nicolas Ferre
Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
On Aug 13 2019, Paul Walmsley wrote: > Dave, Nicolas, > > On Mon, 22 Jul 2019, Yash Shah wrote: > >> On Fri, Jul 19, 2019 at 5:36 PM wrote: >> > >> > On 19/07/2019 at 13:10, Yash Shah wrote: >> > > Update the compatibility string for SiFive FU540-C000 as per the new >> > > string updated in the binding doc. >> > > Reference: https://lkml.org/lkml/2019/7/17/200 >> > >> > Maybe referring to lore.kernel.org is better: >> > https://lore.kernel.org/netdev/caj2_jofevzqat0yprg4hem4jrrqkb72fkseqj4p8p5ka-+r...@mail.gmail.com/ >> >> Sure. Will keep that in mind for future reference. >> >> > >> > > Signed-off-by: Yash Shah >> > >> > Acked-by: Nicolas Ferre >> >> Thanks. > > Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier. > If not, please let us know. This is still missing in v5.4-rc5, which means that networking is broken. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
Dave, Nicolas, On Mon, 22 Jul 2019, Yash Shah wrote: > On Fri, Jul 19, 2019 at 5:36 PM wrote: > > > > On 19/07/2019 at 13:10, Yash Shah wrote: > > > Update the compatibility string for SiFive FU540-C000 as per the new > > > string updated in the binding doc. > > > Reference: https://lkml.org/lkml/2019/7/17/200 > > > > Maybe referring to lore.kernel.org is better: > > https://lore.kernel.org/netdev/caj2_jofevzqat0yprg4hem4jrrqkb72fkseqj4p8p5ka-+r...@mail.gmail.com/ > > Sure. Will keep that in mind for future reference. > > > > > > Signed-off-by: Yash Shah > > > > Acked-by: Nicolas Ferre > > Thanks. Am assuming you'll pick this up for the -net tree for v5.4-rc1 or earlier. If not, please let us know. - Paul
Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
On Fri, 19 Jul 2019, Yash Shah wrote: > Update the compatibility string for SiFive FU540-C000 as per the new > string updated in the binding doc. > Reference: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah Tested-by: Paul Walmsley - Paul
Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
On Fri, 19 Jul 2019, Yash Shah wrote: > Update the compatibility string for SiFive FU540-C000 as per the new > string updated in the binding doc. > Reference: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah Reviewed-by: Paul Walmsley - Paul
Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
On Fri, Jul 19, 2019 at 5:36 PM wrote: > > On 19/07/2019 at 13:10, Yash Shah wrote: > > Update the compatibility string for SiFive FU540-C000 as per the new > > string updated in the binding doc. > > Reference: https://lkml.org/lkml/2019/7/17/200 > > Maybe referring to lore.kernel.org is better: > https://lore.kernel.org/netdev/caj2_jofevzqat0yprg4hem4jrrqkb72fkseqj4p8p5ka-+r...@mail.gmail.com/ Sure. Will keep that in mind for future reference. > > > Signed-off-by: Yash Shah > > Acked-by: Nicolas Ferre Thanks. - Yash
Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
On 19/07/2019 at 13:10, Yash Shah wrote:
> Update the compatibility string for SiFive FU540-C000 as per the new
> string updated in the binding doc.
> Reference: https://lkml.org/lkml/2019/7/17/200
Maybe referring to lore.kernel.org is better:
https://lore.kernel.org/netdev/caj2_jofevzqat0yprg4hem4jrrqkb72fkseqj4p8p5ka-+r...@mail.gmail.com/
> Signed-off-by: Yash Shah
Acked-by: Nicolas Ferre
Thanks, best regards,
Nicolas
> ---
> drivers/net/ethernet/cadence/macb_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c
> b/drivers/net/ethernet/cadence/macb_main.c
> index 15d0737..305371c 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4112,7 +4112,7 @@ static int fu540_c000_init(struct platform_device *pdev)
> { .compatible = "cdns,emac", .data = _config },
> { .compatible = "cdns,zynqmp-gem", .data = _config},
> { .compatible = "cdns,zynq-gem", .data = _config },
> - { .compatible = "sifive,fu540-macb", .data = _c000_config },
> + { .compatible = "sifive,fu540-c000-gem", .data = _c000_config },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, macb_dt_ids);
>
--
Nicolas Ferre
[PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000
Update the compatibility string for SiFive FU540-C000 as per the new
string updated in the binding doc.
Reference: https://lkml.org/lkml/2019/7/17/200
Signed-off-by: Yash Shah
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c
b/drivers/net/ethernet/cadence/macb_main.c
index 15d0737..305371c 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4112,7 +4112,7 @@ static int fu540_c000_init(struct platform_device *pdev)
{ .compatible = "cdns,emac", .data = _config },
{ .compatible = "cdns,zynqmp-gem", .data = _config},
{ .compatible = "cdns,zynq-gem", .data = _config },
- { .compatible = "sifive,fu540-macb", .data = _c000_config },
+ { .compatible = "sifive,fu540-c000-gem", .data = _c000_config },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, macb_dt_ids);
--
1.9.1
