Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/28 16:32, Gang He wrote: > Hi Alex, > > >> Hi Gang, >> >> On 2017/11/28 15:38, Gang He wrote: >>> Hi Alex, >>> >>> >> Hi Gang, On 2017/11/28 13:33, Gang He wrote: > Hello Alex, > > >> Hi Gang, >> >> On 2017/11/27

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/28 16:32, Gang He wrote: > Hi Alex, > > >> Hi Gang, >> >> On 2017/11/28 15:38, Gang He wrote: >>> Hi Alex, >>> >>> >> Hi Gang, On 2017/11/28 13:33, Gang He wrote: > Hello Alex, > > >> Hi Gang, >> >> On 2017/11/27

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 16:54, Gang He wrote: > Hi Joseph, > > > >> >> On 17/11/28 15:24, Gang He wrote: >>> Hello Joseph, >>> >>> >> >>> On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 16:54, Gang He wrote: > Hi Joseph, > > > >> >> On 17/11/28 15:24, Gang He wrote: >>> Hello Joseph, >>> >>> >> >>> On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Joseph, >>> > > On 17/11/28 15:24, Gang He wrote: >> Hello Joseph, >> >> > >> >>> >>> On 17/11/28 11:35, Gang He wrote: Hello Joseph, >>> > Hi Gang, > > On 17/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Joseph, >>> > > On 17/11/28 15:24, Gang He wrote: >> Hello Joseph, >> >> > >> >>> >>> On 17/11/28 11:35, Gang He wrote: Hello Joseph, >>> > Hi Gang, > > On 17/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 15:24, Gang He wrote: > Hello Joseph, > > > >> >> On 17/11/28 11:35, Gang He wrote: >>> Hello Joseph, >>> >>> >> Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks,

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 15:24, Gang He wrote: > Hello Joseph, > > > >> >> On 17/11/28 11:35, Gang He wrote: >>> Hello Joseph, >>> >>> >> Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks,

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Alex, >>> > Hi Gang, > > On 2017/11/28 15:38, Gang He wrote: >> Hi Alex, >> >> > >>> Hi Gang, >>> >>> On 2017/11/28 13:33, Gang He wrote: Hello Alex, >>> > Hi Gang, > > On 2017/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Alex, >>> > Hi Gang, > > On 2017/11/28 15:38, Gang He wrote: >> Hi Alex, >> >> > >>> Hi Gang, >>> >>> On 2017/11/28 13:33, Gang He wrote: Hello Alex, >>> > Hi Gang, > > On 2017/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/28 15:38, Gang He wrote: > Hi Alex, > > >> Hi Gang, >> >> On 2017/11/28 13:33, Gang He wrote: >>> Hello Alex, >>> >>> >> Hi Gang, On 2017/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/28 15:38, Gang He wrote: > Hi Alex, > > >> Hi Gang, >> >> On 2017/11/28 13:33, Gang He wrote: >>> Hello Alex, >>> >>> >> Hi Gang, On 2017/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Alex, >>> > Hi Gang, > > On 2017/11/28 13:33, Gang He wrote: >> Hello Alex, >> >> > >>> Hi Gang, >>> >>> On 2017/11/27 17:46, Gang He wrote: Add ocfs2_overwrite_io function, which is used to judge if overwrite allocated blocks, otherwise, the write will bring extra

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Alex, >>> > Hi Gang, > > On 2017/11/28 13:33, Gang He wrote: >> Hello Alex, >> >> > >>> Hi Gang, >>> >>> On 2017/11/27 17:46, Gang He wrote: Add ocfs2_overwrite_io function, which is used to judge if overwrite allocated blocks, otherwise, the write will bring extra

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 2017/11/28 13:44, Gang He wrote: > Hi Changwei, > > >> Hi, >> Gang >> >> On 2017/11/27 17:48, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >> >> Can

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 2017/11/28 13:44, Gang He wrote: > Hi Changwei, > > >> Hi, >> Gang >> >> On 2017/11/27 17:48, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >> >> Can

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hello Joseph, >>> > > On 17/11/28 11:35, Gang He wrote: >> Hello Joseph, >> >> > >>> Hi Gang, >>> >>> On 17/11/27 17:46, Gang He wrote: Add ocfs2_overwrite_io function, which is used to judge if overwrite allocated blocks, otherwise, the write will bring extra block

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hello Joseph, >>> > > On 17/11/28 11:35, Gang He wrote: >> Hello Joseph, >> >> > >>> Hi Gang, >>> >>> On 17/11/27 17:46, Gang He wrote: Add ocfs2_overwrite_io function, which is used to judge if overwrite allocated blocks, otherwise, the write will bring extra block

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/28 13:33, Gang He wrote: > Hello Alex, > > >> Hi Gang, >> >> On 2017/11/27 17:46, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/28 13:33, Gang He wrote: > Hello Alex, > > >> Hi Gang, >> >> On 2017/11/27 17:46, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Changwei, >>> > Hi, > Gang > > On 2017/11/27 17:48, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if >> overwrite allocated blocks, otherwise, the write will bring extra >> block allocation overhead. >> > > Can you elaborate how this overhead is introduced? >

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Changwei, >>> > Hi, > Gang > > On 2017/11/27 17:48, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if >> overwrite allocated blocks, otherwise, the write will bring extra >> block allocation overhead. >> > > Can you elaborate how this overhead is introduced? >

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hello Alex, >>> > Hi Gang, > > On 2017/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if >> overwrite allocated blocks, otherwise, the write will bring extra >> block allocation overhead. >> >> Signed-off-by: Gang He >> --- >>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hello Alex, >>> > Hi Gang, > > On 2017/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if >> overwrite allocated blocks, otherwise, the write will bring extra >> block allocation overhead. >> >> Signed-off-by: Gang He >> --- >> fs/ocfs2/extent_map.c |

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

>>> > On 2017/11/28 9:52, piaojun wrote: >> Hi Gang, >> >> If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if >> we can discard 'int wait' just as ext4 does: >> >> static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); > > Yes, Jun has a point. > It

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

>>> > On 2017/11/28 9:52, piaojun wrote: >> Hi Gang, >> >> If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if >> we can discard 'int wait' just as ext4 does: >> >> static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); > > Yes, Jun has a point. > It

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Jun, >>> > Hi Gang, > > If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if > we can discard 'int wait' just as ext4 does: > > static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); Ok, it looks most people prefer to get rid of "wait" parameter.

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Jun, >>> > Hi Gang, > > If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if > we can discard 'int wait' just as ext4 does: > > static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); Ok, it looks most people prefer to get rid of "wait" parameter.

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hello Joseph, >>> > Hi Gang, > > On 17/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if >> overwrite allocated blocks, otherwise, the write will bring extra >> block allocation overhead. >> >> Signed-off-by: Gang He >> --- >>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hello Joseph, >>> > Hi Gang, > > On 17/11/27 17:46, Gang He wrote: >> Add ocfs2_overwrite_io function, which is used to judge if >> overwrite allocated blocks, otherwise, the write will bring extra >> block allocation overhead. >> >> Signed-off-by: Gang He >> --- >> fs/ocfs2/extent_map.c |

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi, Gang On 2017/11/27 17:48, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > Can you elaborate how this overhead is introduced? Forgive me, I don't figure it. Thanks,

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi, Gang On 2017/11/27 17:48, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > Can you elaborate how this overhead is introduced? Forgive me, I don't figure it. Thanks,

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > > Signed-off-by: Gang He > --- > fs/ocfs2/extent_map.c | 67 >

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 2017/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > > Signed-off-by: Gang He > --- > fs/ocfs2/extent_map.c | 67 >

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 2017/11/28 9:52, piaojun wrote: > Hi Gang, > > If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if > we can discard 'int wait' just as ext4 does: > > static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); Yes, Jun has a point. It seems that

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 2017/11/28 9:52, piaojun wrote: > Hi Gang, > > If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if > we can discard 'int wait' just as ext4 does: > > static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); Yes, Jun has a point. It seems that

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if we can discard 'int wait' just as ext4 does: static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); thans, Jun On 2017/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, If ocfs2_overwrite_io is only called in 'nowait' scenarios, I wonder if we can discard 'int wait' just as ext4 does: static bool ext4_overwrite_io(struct inode *inode, loff_t pos, loff_t len); thans, Jun On 2017/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > > Signed-off-by: Gang He > --- > fs/ocfs2/extent_map.c | 67 >

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > > Signed-off-by: Gang He > --- > fs/ocfs2/extent_map.c | 67 >

[PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Add ocfs2_overwrite_io function, which is used to judge if overwrite allocated blocks, otherwise, the write will bring extra block allocation overhead. Signed-off-by: Gang He --- fs/ocfs2/extent_map.c | 67 +++ fs/ocfs2/extent_map.h

[PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Add ocfs2_overwrite_io function, which is used to judge if overwrite allocated blocks, otherwise, the write will bring extra block allocation overhead. Signed-off-by: Gang He --- fs/ocfs2/extent_map.c | 67 +++ fs/ocfs2/extent_map.h | 3 +++ 2