Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-12-10 Thread Frederic Weisbecker
On Tue, Dec 10, 2013 at 05:22:29PM +0100, Oleg Nesterov wrote: > On 12/10, Frederic Weisbecker wrote: > > > > On Wed, Oct 02, 2013 at 11:11:07AM -0500, suravee.suthikulpa...@amd.com > > wrote: > > > @@ -525,14 +525,11 @@ int parse_events_add_breakpoint(struct list_head > > > *list, int *idx, > >

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-12-10 Thread Oleg Nesterov
On 12/10, Frederic Weisbecker wrote: > > On Wed, Oct 02, 2013 at 11:11:07AM -0500, suravee.suthikulpa...@amd.com wrote: > > @@ -525,14 +525,11 @@ int parse_events_add_breakpoint(struct list_head > > *list, int *idx, > > if (parse_breakpoint_type(type, )) > > return -EINVAL; > > >

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-12-10 Thread Frederic Weisbecker
On Wed, Oct 02, 2013 at 11:11:07AM -0500, suravee.suthikulpa...@amd.com wrote: > From: Jacob Shin > > Currently bp_len is given a default value of 4. Allow user to override it: > > $ perf stat -e mem:0x1000/8 > ^ > bp_len > > If no

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-12-10 Thread Frederic Weisbecker
On Wed, Oct 02, 2013 at 11:11:07AM -0500, suravee.suthikulpa...@amd.com wrote: From: Jacob Shin jacob.w.s...@gmail.com Currently bp_len is given a default value of 4. Allow user to override it: $ perf stat -e mem:0x1000/8 ^ bp_len

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-12-10 Thread Oleg Nesterov
On 12/10, Frederic Weisbecker wrote: On Wed, Oct 02, 2013 at 11:11:07AM -0500, suravee.suthikulpa...@amd.com wrote: @@ -525,14 +525,11 @@ int parse_events_add_breakpoint(struct list_head *list, int *idx, if (parse_breakpoint_type(type, attr)) return -EINVAL; - /*

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-12-10 Thread Frederic Weisbecker
On Tue, Dec 10, 2013 at 05:22:29PM +0100, Oleg Nesterov wrote: On 12/10, Frederic Weisbecker wrote: On Wed, Oct 02, 2013 at 11:11:07AM -0500, suravee.suthikulpa...@amd.com wrote: @@ -525,14 +525,11 @@ int parse_events_add_breakpoint(struct list_head *list, int *idx, if

[PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-10-02 Thread suravee.suthikulpanit
From: Jacob Shin Currently bp_len is given a default value of 4. Allow user to override it: $ perf stat -e mem:0x1000/8 ^ bp_len If no value is given, it will default to 4 as it did before. Signed-off-by: Jacob Shin Signed-off-by:

[PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-10-02 Thread suravee.suthikulpanit
From: Jacob Shin jacob.w.s...@gmail.com Currently bp_len is given a default value of 4. Allow user to override it: $ perf stat -e mem:0x1000/8 ^ bp_len If no value is given, it will default to 4 as it did before. Signed-off-by: Jacob

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-28 Thread Oleg Nesterov
On 04/27, H. Peter Anvin wrote: > > On 04/27/2013 09:58 AM, Oleg Nesterov wrote: > > > > Stupid question... So X86_FEATURE_BPEXT only works for r/w? I mean, it > > doesn't allow to specify the mask for an execute breakpoint? > > x86 execute breakpoints in general are only a single byte, which has

[PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-28 Thread Jacob Shin
Currently bp_len is given a default value of 4. Allow user to override it: $ perf stat -e mem:0x1000/8 ^ bp_len If no value is given, it will default to 4 as it did before. Signed-off-by: Jacob Shin ---

[PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-28 Thread Jacob Shin
Currently bp_len is given a default value of 4. Allow user to override it: $ perf stat -e mem:0x1000/8 ^ bp_len If no value is given, it will default to 4 as it did before. Signed-off-by: Jacob Shin jacob.s...@amd.com ---

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-28 Thread Oleg Nesterov
On 04/27, H. Peter Anvin wrote: On 04/27/2013 09:58 AM, Oleg Nesterov wrote: Stupid question... So X86_FEATURE_BPEXT only works for r/w? I mean, it doesn't allow to specify the mask for an execute breakpoint? x86 execute breakpoints in general are only a single byte, which has to be the

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread H. Peter Anvin
On 04/27/2013 09:58 AM, Oleg Nesterov wrote: > > Stupid question... So X86_FEATURE_BPEXT only works for r/w? I mean, it > doesn't allow to specify the mask for an execute breakpoint? > x86 execute breakpoints in general are only a single byte, which has to be the first byte of the instruction.

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread Jacob Shin
On Sat, Apr 27, 2013 at 07:34:24PM +0200, Oleg Nesterov wrote: > On 04/27, Oleg Nesterov wrote: > > > > On 04/26, Jacob Shin wrote: > > > > > > @@ -518,12 +518,10 @@ int parse_events_add_breakpoint(struct list_head > > > **list, int *idx, > > > if (parse_breakpoint_type(type, )) > > >

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread Oleg Nesterov
On 04/27, Oleg Nesterov wrote: > > On 04/26, Jacob Shin wrote: > > > > @@ -518,12 +518,10 @@ int parse_events_add_breakpoint(struct list_head > > **list, int *idx, > > if (parse_breakpoint_type(type, )) > > return -EINVAL; > > > > - /* > > -* We should find a nice way to

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread Oleg Nesterov
On 04/26, Jacob Shin wrote: > > @@ -518,12 +518,10 @@ int parse_events_add_breakpoint(struct list_head > **list, int *idx, > if (parse_breakpoint_type(type, )) > return -EINVAL; > > - /* > - * We should find a nice way to override the access length > - * Provide

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread Oleg Nesterov
On 04/26, Jacob Shin wrote: @@ -518,12 +518,10 @@ int parse_events_add_breakpoint(struct list_head **list, int *idx, if (parse_breakpoint_type(type, attr)) return -EINVAL; - /* - * We should find a nice way to override the access length - * Provide some

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread Oleg Nesterov
On 04/27, Oleg Nesterov wrote: On 04/26, Jacob Shin wrote: @@ -518,12 +518,10 @@ int parse_events_add_breakpoint(struct list_head **list, int *idx, if (parse_breakpoint_type(type, attr)) return -EINVAL; - /* -* We should find a nice way to override the

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread Jacob Shin
On Sat, Apr 27, 2013 at 07:34:24PM +0200, Oleg Nesterov wrote: On 04/27, Oleg Nesterov wrote: On 04/26, Jacob Shin wrote: @@ -518,12 +518,10 @@ int parse_events_add_breakpoint(struct list_head **list, int *idx, if (parse_breakpoint_type(type, attr)) return -EINVAL;

Re: [PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-27 Thread H. Peter Anvin
On 04/27/2013 09:58 AM, Oleg Nesterov wrote: Stupid question... So X86_FEATURE_BPEXT only works for r/w? I mean, it doesn't allow to specify the mask for an execute breakpoint? x86 execute breakpoints in general are only a single byte, which has to be the first byte of the instruction.

[PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-26 Thread Jacob Shin
Currently bp_len is given a default value of 4. Allow user to override it: $ perf stat -e mem:0x1000/8 ^ bp_len If no value is given, it will default to 4 as it did before. Signed-off-by: Jacob Shin ---

[PATCH 2/3] perf tools: allow user to specify hardware breakpoint bp_len

2013-04-26 Thread Jacob Shin
Currently bp_len is given a default value of 4. Allow user to override it: $ perf stat -e mem:0x1000/8 ^ bp_len If no value is given, it will default to 4 as it did before. Signed-off-by: Jacob Shin jacob.s...@amd.com ---