Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-10 Thread Axel Lin
2013/2/8, Mark Brown : > On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote: > >> Use >dev rather than iodev->dev for dev_err(), dev_warn() and >> dev_info(). > > It's not clear to me that this is actually an improvement, the pdev is > mostly just an internal Linux implementation detail so

Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-10 Thread Axel Lin
2013/2/8, Mark Brown broo...@opensource.wolfsonmicro.com: On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote: Use pdev-dev rather than iodev-dev for dev_err(), dev_warn() and dev_info(). It's not clear to me that this is actually an improvement, the pdev is mostly just an internal

Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-08 Thread Mark Brown
On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote: > Use >dev rather than iodev->dev for dev_err(), dev_warn() and > dev_info(). It's not clear to me that this is actually an improvement, the pdev is mostly just an internal Linux implementation detail so it's common to use the physical

Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-08 Thread Mark Brown
On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote: Use pdev-dev rather than iodev-dev for dev_err(), dev_warn() and dev_info(). It's not clear to me that this is actually an improvement, the pdev is mostly just an internal Linux implementation detail so it's common to use the physical

[PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-05 Thread Axel Lin
Use >dev rather than iodev->dev for dev_err(), dev_warn() and dev_info(). Use >dev rather than iodev->dev for devm_kzalloc() and of_get_regulator_init_data(), this fixes memory leak. Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c | 47 ++- 1

[PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-05 Thread Axel Lin
Use pdev-dev rather than iodev-dev for dev_err(), dev_warn() and dev_info(). Use pdev-dev rather than iodev-dev for devm_kzalloc() and of_get_regulator_init_data(), this fixes memory leak. Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/s5m8767.c | 47