Re: [PATCH 2/3] spi: mediatek: support adjust register define

2017-06-07 Thread lei liu
On Tue, 2017-06-06 at 19:57 +0100, Mark Brown wrote: > On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote: > > > + /* some IC design adjust register define */ > > + bool adjust_reg; > > Can we have a name that's more specific to the particular quirk please? > The current name will get

Re: [PATCH 2/3] spi: mediatek: support adjust register define

2017-06-07 Thread lei liu
On Tue, 2017-06-06 at 19:57 +0100, Mark Brown wrote: > On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote: > > > + /* some IC design adjust register define */ > > + bool adjust_reg; > > Can we have a name that's more specific to the particular quirk please? > The current name will get

Re: [PATCH 2/3] spi: mediatek: support adjust register define

2017-06-06 Thread Mark Brown
On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote: > + /* some IC design adjust register define */ > + bool adjust_reg; Can we have a name that's more specific to the particular quirk please? The current name will get confusing if some future chip also needs slightly different

Re: [PATCH 2/3] spi: mediatek: support adjust register define

2017-06-06 Thread Mark Brown
On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote: > + /* some IC design adjust register define */ > + bool adjust_reg; Can we have a name that's more specific to the particular quirk please? The current name will get confusing if some future chip also needs slightly different

[PATCH 2/3] spi: mediatek: support adjust register define

2017-06-02 Thread Leilk Liu
this patch adds support for adjust register design. Signed-off-by: Leilk Liu --- drivers/spi/spi-mt65xx.c | 45 ++ include/linux/platform_data/spi-mt65xx.h |2 ++ 2 files changed, 42 insertions(+), 5 deletions(-) diff

[PATCH 2/3] spi: mediatek: support adjust register define

2017-06-02 Thread Leilk Liu
this patch adds support for adjust register design. Signed-off-by: Leilk Liu --- drivers/spi/spi-mt65xx.c | 45 ++ include/linux/platform_data/spi-mt65xx.h |2 ++ 2 files changed, 42 insertions(+), 5 deletions(-) diff --git