Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:34 +0530, Varka Bhadram wrote: > On 08/05/2014 05:32 PM, Alan Cox wrote: > > On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: > >> On 08/05/2014 04:24 PM, Matthias Brugger wrote: > >> > >> (...) > >> > >>> +#include > >>> +#include > >>> +#include > >>> +#include

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include +#include +#include +#include +#include +#include +#include +#include +#include "8250.h" + Better if we have includes in

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: > On 08/05/2014 04:24 PM, Matthias Brugger wrote: > > (...) > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include "8250.h" > > + > > Better if we have

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include +#include +#include +#include +#include +#include +#include +#include +#include "8250.h" + Better if we have includes in alphabetical order.. +#define MTK_UART_RATE_FIX 0x0D /* UART Rate Fix Register */ + +struct

[PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Matthias Brugger
This patch adds support for the UART block found on Mediatek SoCs. The driver uses the highspeed capability of the 8250_core to set the highspeed register and calculate the divisor for it. Signed-off-by: Matthias Brugger --- drivers/tty/serial/8250/8250_mtk.c | 211

[PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Matthias Brugger
This patch adds support for the UART block found on Mediatek SoCs. The driver uses the highspeed capability of the 8250_core to set the highspeed register and calculate the divisor for it. Signed-off-by: Matthias Brugger matthias@gmail.com --- drivers/tty/serial/8250/8250_mtk.c | 211

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h +#include linux/of_irq.h +#include linux/of_platform.h +#include linux/platform_device.h +#include linux/clk.h +#include linux/pm_runtime.h +#include 8250.h +

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h +#include linux/of_irq.h +#include linux/of_platform.h +#include linux/platform_device.h

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h +#include linux/of_irq.h +#include linux/of_platform.h +#include

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Alan Cox
On Tue, 2014-08-05 at 17:34 +0530, Varka Bhadram wrote: On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h