Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-23 Thread Nicolas Pitre
@Russell: Can I have your ACK on this patch before I send the series upstream? Here's the revised version accounting for the changes the discussion in this thread brought about Author: Nicolas Pitre Date: Fri Jul 18 00:07:05 2014 -0400 ARM: add IPI tracepoints The strings used

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-19 Thread Nicolas Pitre
On Sat, 19 Jul 2014, Ard Biesheuvel wrote: > On 18 July 2014 23:22, Steven Rostedt wrote: > > On Fri, 18 Jul 2014 16:55:42 -0400 (EDT) > > Nicolas Pitre wrote: > > > >> > >> Here's the patch I have at the head of the series now, with the above > >> ugliness changed to an unconditional __tracepoi

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-19 Thread Steven Rostedt
On Sat, 19 Jul 2014 22:50:16 +0200 Ard Biesheuvel wrote: > OK, so if the general case has been fixed, perhaps we should ask Paul > to drop my patch? > No, for a few reasons. One, this patch still needs to get in to fix the problem for RCU. Two, RCU basically open codes the creation of the str

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-19 Thread Ard Biesheuvel
On 19 July 2014 22:28, Steven Rostedt wrote: > On Sat, 19 Jul 2014 21:10:37 +0200 > Ard Biesheuvel wrote: > >> On 18 July 2014 23:22, Steven Rostedt wrote: >> > On Fri, 18 Jul 2014 16:55:42 -0400 (EDT) >> > Nicolas Pitre wrote: >> > >> >> >> >> Here's the patch I have at the head of the series

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-19 Thread Steven Rostedt
On Sat, 19 Jul 2014 21:10:37 +0200 Ard Biesheuvel wrote: > On 18 July 2014 23:22, Steven Rostedt wrote: > > On Fri, 18 Jul 2014 16:55:42 -0400 (EDT) > > Nicolas Pitre wrote: > > > >> > >> Here's the patch I have at the head of the series now, with the above > >> ugliness changed to an unconditi

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-19 Thread Ard Biesheuvel
On 18 July 2014 23:22, Steven Rostedt wrote: > On Fri, 18 Jul 2014 16:55:42 -0400 (EDT) > Nicolas Pitre wrote: > >> >> Here's the patch I have at the head of the series now, with the above >> ugliness changed to an unconditional __tracepoint_string attribute. >> > > I was thinking of something li

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-18 Thread Steven Rostedt
On Fri, 18 Jul 2014 22:55:12 -0400 (EDT) Nicolas Pitre wrote: > Any comments / ACKs on the other patches? I'd like to see 1/4 to 3/4 > (and your patch) merged upstream during the next window. 4/4 is up for > debate. You can add my Acked-by for patches 1,2 and 3, after the clean up of the #if

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-18 Thread Nicolas Pitre
On Fri, 18 Jul 2014, Steven Rostedt wrote: > On Fri, 18 Jul 2014 16:55:42 -0400 (EDT) > Nicolas Pitre wrote: > > > > > Here's the patch I have at the head of the series now, with the above > > ugliness changed to an unconditional __tracepoint_string attribute. > > > > I was thinking of someth

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-18 Thread Steven Rostedt
On Fri, 18 Jul 2014 16:55:42 -0400 (EDT) Nicolas Pitre wrote: > > Here's the patch I have at the head of the series now, with the above > ugliness changed to an unconditional __tracepoint_string attribute. > I was thinking of something like this. Feel free to add this to your series. -- Steve

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-18 Thread Nicolas Pitre
On Fri, 18 Jul 2014, Steven Rostedt wrote: > On Fri, 18 Jul 2014 01:18:53 -0400 > Nicolas Pitre wrote: > > > > -#ifdef CONFIG_IRQ_WORK > > -void arch_irq_work_raise(void) > > -{ > > - if (is_smp()) > > - smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK); > > -} > > +sta

Re: [PATCH 2/4] ARM: add IPI tracepoints

2014-07-18 Thread Steven Rostedt
On Fri, 18 Jul 2014 01:18:53 -0400 Nicolas Pitre wrote: > -#ifdef CONFIG_IRQ_WORK > -void arch_irq_work_raise(void) > -{ > - if (is_smp()) > - smp_cross_call(cpumask_of(smp_processor_id()), IPI_IRQ_WORK); > -} > +static const char *ipi_types[NR_IPI] > +#ifdef CONFIG_TRACING > +

[PATCH 2/4] ARM: add IPI tracepoints

2014-07-17 Thread Nicolas Pitre
The strings used to list IPIs in /proc/interrupts are reused for tracing purposes. Signed-off-by: Nicolas Pitre --- arch/arm/kernel/smp.c | 72 --- 1 file changed, 45 insertions(+), 27 deletions(-) diff --git a/arch/arm/kernel/smp.c b/arch/arm/ker