Re: [PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Dan Carpenter
Guys, please stop accepting patches from Markus! Markus, you always introduce bugs. I have asked you over and over to stop sending "cleanup patches" because you are not careful. If you restricted yourself to fixing bugs only then you would maybe fix more bugs than you introduce but as it you

Re: [PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Dan Carpenter
Guys, please stop accepting patches from Markus! Markus, you always introduce bugs. I have asked you over and over to stop sending "cleanup patches" because you are not careful. If you restricted yourself to fixing bugs only then you would maybe fix more bugs than you introduce but as it you

[PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 21 Sep 2016 22:33:54 +0200 Move the assignments for three data structure members to the end so that they will only be performed if the desired resource allocations succeeded by this function. Signed-off-by: Markus Elfring

[PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 21 Sep 2016 22:33:54 +0200 Move the assignments for three data structure members to the end so that they will only be performed if the desired resource allocations succeeded by this function. Signed-off-by: Markus Elfring --- drivers/gpu/drm/qxl/qxl_kms.c | 9