Re: [PATCH 2/4] pinctrl: add helpers for group based drivers

2014-11-03 Thread Linus Walleij
On Thu, Oct 30, 2014 at 8:48 PM, Antoine Tenart wrote: > Maybe the of_pinctrl_utils_node_is_mux/config() solution is more > appropriate to avoid having a confusing function. Plus we would have a > dedicated of_pinctrl_utils_read_pins() function. > > I think I prefer the second solution because

Re: [PATCH 2/4] pinctrl: add helpers for group based drivers

2014-11-03 Thread Linus Walleij
On Thu, Oct 30, 2014 at 8:48 PM, Antoine Tenart antoine.ten...@free-electrons.com wrote: Maybe the of_pinctrl_utils_node_is_mux/config() solution is more appropriate to avoid having a confusing function. Plus we would have a dedicated of_pinctrl_utils_read_pins() function. I think I prefer

Re: [PATCH 2/4] pinctrl: add helpers for group based drivers

2014-10-30 Thread Antoine Tenart
Hi Linus, On Tue, Oct 28, 2014 at 04:38:27PM +0100, Linus Walleij wrote: > On Mon, Oct 20, 2014 at 10:04 AM, Antoine Tenart > wrote: > > > +#ifdef CONFIG_OF > > +int of_pinctrl_utils_read_function(struct pinctrl_dev *pctldev, > > + struct device_node *node, const char

Re: [PATCH 2/4] pinctrl: add helpers for group based drivers

2014-10-30 Thread Antoine Tenart
Hi Linus, On Tue, Oct 28, 2014 at 04:38:27PM +0100, Linus Walleij wrote: On Mon, Oct 20, 2014 at 10:04 AM, Antoine Tenart antoine.ten...@free-electrons.com wrote: +#ifdef CONFIG_OF +int of_pinctrl_utils_read_function(struct pinctrl_dev *pctldev, + struct device_node *node,

Re: [PATCH 2/4] pinctrl: add helpers for group based drivers

2014-10-28 Thread Linus Walleij
On Mon, Oct 20, 2014 at 10:04 AM, Antoine Tenart wrote: > Since the group based drivers have their dt properties documented in the > generic pinctrl documentation, add generic helpers to avoid duplicating > code and to be sure new drivers won't use specific bindings for a known > purpose. > >

Re: [PATCH 2/4] pinctrl: add helpers for group based drivers

2014-10-28 Thread Linus Walleij
On Mon, Oct 20, 2014 at 10:04 AM, Antoine Tenart antoine.ten...@free-electrons.com wrote: Since the group based drivers have their dt properties documented in the generic pinctrl documentation, add generic helpers to avoid duplicating code and to be sure new drivers won't use specific bindings

[PATCH 2/4] pinctrl: add helpers for group based drivers

2014-10-20 Thread Antoine Tenart
Since the group based drivers have their dt properties documented in the generic pinctrl documentation, add generic helpers to avoid duplicating code and to be sure new drivers won't use specific bindings for a known purpose. This patch add two functions to help group based drivers map their

[PATCH 2/4] pinctrl: add helpers for group based drivers

2014-10-20 Thread Antoine Tenart
Since the group based drivers have their dt properties documented in the generic pinctrl documentation, add generic helpers to avoid duplicating code and to be sure new drivers won't use specific bindings for a known purpose. This patch add two functions to help group based drivers map their