Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-10-08 Thread Christian Ruppert
On Wed, Aug 28, 2013 at 04:47:36PM +0200, Christian Ruppert wrote: > On Thu, Aug 22, 2013 at 02:10:55PM -0600, Stephen Warren wrote: > [...] > > Pin groups are supposed to be something that represents some property of > > the pinctrl HW itself. So, if you have register "X" bits 3-0 that define > >

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-10-08 Thread Christian Ruppert
On Wed, Aug 28, 2013 at 04:47:36PM +0200, Christian Ruppert wrote: On Thu, Aug 22, 2013 at 02:10:55PM -0600, Stephen Warren wrote: [...] Pin groups are supposed to be something that represents some property of the pinctrl HW itself. So, if you have register X bits 3-0 that define the mux

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-30 Thread Christian Ruppert
On Thu, Aug 29, 2013 at 10:24:30AM +0200, Linus Walleij wrote: > On Thu, Aug 29, 2013 at 9:35 AM, Christian Ruppert > wrote: > > On Wed, Aug 28, 2013 at 08:49:36PM +0200, Linus Walleij wrote: > >> On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert > >> wrote: > >> > On Wed, Aug 14, 2013 at

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-30 Thread Christian Ruppert
On Thu, Aug 29, 2013 at 10:24:30AM +0200, Linus Walleij wrote: On Thu, Aug 29, 2013 at 9:35 AM, Christian Ruppert christian.rupp...@abilis.com wrote: On Wed, Aug 28, 2013 at 08:49:36PM +0200, Linus Walleij wrote: On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-29 Thread Linus Walleij
On Thu, Aug 29, 2013 at 9:35 AM, Christian Ruppert wrote: > On Wed, Aug 28, 2013 at 08:49:36PM +0200, Linus Walleij wrote: >> On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert >> wrote: >> > On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: >> >> >> >> OK, that can also be called a

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-29 Thread Christian Ruppert
On Wed, Aug 28, 2013 at 08:49:36PM +0200, Linus Walleij wrote: > On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert > wrote: > > On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: > >> > >> OK, that can also be called a "bank" or "register" but whatever. > > > > As you suggested below

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-29 Thread Christian Ruppert
On Wed, Aug 28, 2013 at 08:49:36PM +0200, Linus Walleij wrote: On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert christian.rupp...@abilis.com wrote: On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: OK, that can also be called a bank or register but whatever. As you

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-29 Thread Linus Walleij
On Thu, Aug 29, 2013 at 9:35 AM, Christian Ruppert christian.rupp...@abilis.com wrote: On Wed, Aug 28, 2013 at 08:49:36PM +0200, Linus Walleij wrote: On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert christian.rupp...@abilis.com wrote: On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-28 Thread Linus Walleij
On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert wrote: > On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: >> >> OK, that can also be called a "bank" or "register" but whatever. > > As you suggested below I re-read Documentation/pinctrl.txt and it got me > even more confused: > Am

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-28 Thread Christian Ruppert
On Thu, Aug 22, 2013 at 02:10:55PM -0600, Stephen Warren wrote: > On 08/21/2013 09:57 AM, Christian Ruppert wrote: > > On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: > >> On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert > >> wrote: > >>> [Me] > I don't see any of the port

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-28 Thread Christian Ruppert
On Thu, Aug 22, 2013 at 02:10:55PM -0600, Stephen Warren wrote: On 08/21/2013 09:57 AM, Christian Ruppert wrote: On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert christian.rupp...@abilis.com wrote: [Me] I don't see any of

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-28 Thread Linus Walleij
On Wed, Aug 21, 2013 at 5:57 PM, Christian Ruppert christian.rupp...@abilis.com wrote: On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: OK, that can also be called a bank or register but whatever. As you suggested below I re-read Documentation/pinctrl.txt and it got me even

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-22 Thread Stephen Warren
On 08/21/2013 09:57 AM, Christian Ruppert wrote: > On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: >> On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert >> wrote: >>> [Me] I don't see any of the port concept creeping into the device tree in this version and that is how I

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-22 Thread Stephen Warren
On 08/21/2013 09:57 AM, Christian Ruppert wrote: On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert christian.rupp...@abilis.com wrote: [Me] I don't see any of the port concept creeping into the device tree in this version and

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-21 Thread Christian Ruppert
On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: > On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert > wrote: > > [Me] > >> I don't see any of the port concept creeping into the device tree > >> in this version and that is how I think it should be kept: > >> the "port" particulars

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-21 Thread Christian Ruppert
On Wed, Aug 14, 2013 at 06:53:56PM +0200, Linus Walleij wrote: On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert christian.rupp...@abilis.com wrote: [Me] I don't see any of the port concept creeping into the device tree in this version and that is how I think it should be kept: the port

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-14 Thread Linus Walleij
On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert wrote: > [Me] >> I don't see any of the port concept creeping into the device tree >> in this version and that is how I think it should be kept: >> the "port" particulars is a thing for the driver and not the >> device tree. > > I'm not sure if

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-14 Thread Linus Walleij
On Mon, Aug 5, 2013 at 1:51 PM, Christian Ruppert christian.rupp...@abilis.com wrote: [Me] I don't see any of the port concept creeping into the device tree in this version and that is how I think it should be kept: the port particulars is a thing for the driver and not the device tree. I'm

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-05 Thread Christian Ruppert
On Tue, Jul 30, 2013 at 12:35:03AM +0200, Linus Walleij wrote: > Sorry for taking eternities to look into this. > > On Tue, Jun 18, 2013 at 11:29 AM, Christian Ruppert > wrote: > > > The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. > > Used to control the pinmux and

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-08-05 Thread Christian Ruppert
On Tue, Jul 30, 2013 at 12:35:03AM +0200, Linus Walleij wrote: Sorry for taking eternities to look into this. On Tue, Jun 18, 2013 at 11:29 AM, Christian Ruppert christian.rupp...@abilis.com wrote: The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Used to

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-29 Thread Linus Walleij
Sorry for taking eternities to look into this. On Tue, Jun 18, 2013 at 11:29 AM, Christian Ruppert wrote: > The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. > Used to control the pinmux and is a prerequisite for the GPIO driver. > > Signed-off-by: Christian Ruppert

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-29 Thread Linus Walleij
Sorry for taking eternities to look into this. On Tue, Jun 18, 2013 at 11:29 AM, Christian Ruppert christian.rupp...@abilis.com wrote: The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Used to control the pinmux and is a prerequisite for the GPIO driver.

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-26 Thread Stephen Warren
On 07/26/2013 03:42 AM, Christian Ruppert wrote: > On Thu, Jul 18, 2013 at 01:54:18PM -0600, Stephen Warren wrote: >> On 07/18/2013 10:07 AM, Christian Ruppert wrote: >> ... >>> Well, perhaps my definition of "inside"/"outside" pins was not quite >>> clear: The pin groups define the set of (kernel

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-26 Thread Christian Ruppert
On Thu, Jul 18, 2013 at 01:54:18PM -0600, Stephen Warren wrote: > On 07/18/2013 10:07 AM, Christian Ruppert wrote: > ... > > Well, perhaps my definition of "inside"/"outside" pins was not quite > > clear: The pin groups define the set of (kernel internal) pin numbers of > > "outside" pins which

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-26 Thread Christian Ruppert
On Thu, Jul 18, 2013 at 01:54:18PM -0600, Stephen Warren wrote: On 07/18/2013 10:07 AM, Christian Ruppert wrote: ... Well, perhaps my definition of inside/outside pins was not quite clear: The pin groups define the set of (kernel internal) pin numbers of outside pins which are used by pin

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-26 Thread Stephen Warren
On 07/26/2013 03:42 AM, Christian Ruppert wrote: On Thu, Jul 18, 2013 at 01:54:18PM -0600, Stephen Warren wrote: On 07/18/2013 10:07 AM, Christian Ruppert wrote: ... Well, perhaps my definition of inside/outside pins was not quite clear: The pin groups define the set of (kernel internal) pin

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-18 Thread Stephen Warren
On 07/18/2013 10:07 AM, Christian Ruppert wrote: ... > Well, perhaps my definition of "inside"/"outside" pins was not quite > clear: The pin groups define the set of (kernel internal) pin numbers of > "outside" pins which are used by pin controller to map a given > interface. Inside pins are not

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-18 Thread Christian Ruppert
On Tue, Jul 16, 2013 at 10:04:03AM -0600, Stephen Warren wrote: > On 07/16/2013 02:47 AM, Christian Ruppert wrote: > > On Wed, Jul 10, 2013 at 01:27:52PM -0600, Stephen Warren wrote: > >> On 07/08/2013 07:02 AM, Christian Ruppert wrote: > >> ... > >>> OK, a small drawing of our hardware should

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-18 Thread Christian Ruppert
On Tue, Jul 16, 2013 at 10:04:03AM -0600, Stephen Warren wrote: On 07/16/2013 02:47 AM, Christian Ruppert wrote: On Wed, Jul 10, 2013 at 01:27:52PM -0600, Stephen Warren wrote: On 07/08/2013 07:02 AM, Christian Ruppert wrote: ... OK, a small drawing of our hardware should make this clear,

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-18 Thread Stephen Warren
On 07/18/2013 10:07 AM, Christian Ruppert wrote: ... Well, perhaps my definition of inside/outside pins was not quite clear: The pin groups define the set of (kernel internal) pin numbers of outside pins which are used by pin controller to map a given interface. Inside pins are not numbered

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-16 Thread Stephen Warren
On 07/16/2013 02:47 AM, Christian Ruppert wrote: > On Wed, Jul 10, 2013 at 01:27:52PM -0600, Stephen Warren wrote: >> On 07/08/2013 07:02 AM, Christian Ruppert wrote: >> ... >>> OK, a small drawing of our hardware should make this clear, let's take >>> an imaginary example of one port with 10

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-16 Thread Christian Ruppert
On Wed, Jul 10, 2013 at 01:27:52PM -0600, Stephen Warren wrote: > On 07/08/2013 07:02 AM, Christian Ruppert wrote: > ... > > OK, a small drawing of our hardware should make this clear, let's take > > an imaginary example of one port with 10 pins, one i2c interface, one > > spi interface and one

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-16 Thread Christian Ruppert
On Wed, Jul 10, 2013 at 01:27:52PM -0600, Stephen Warren wrote: On 07/08/2013 07:02 AM, Christian Ruppert wrote: ... OK, a small drawing of our hardware should make this clear, let's take an imaginary example of one port with 10 pins, one i2c interface, one spi interface and one GPIO bank:

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-16 Thread Stephen Warren
On 07/16/2013 02:47 AM, Christian Ruppert wrote: On Wed, Jul 10, 2013 at 01:27:52PM -0600, Stephen Warren wrote: On 07/08/2013 07:02 AM, Christian Ruppert wrote: ... OK, a small drawing of our hardware should make this clear, let's take an imaginary example of one port with 10 pins, one i2c

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-10 Thread Stephen Warren
On 07/08/2013 07:02 AM, Christian Ruppert wrote: ... > OK, a small drawing of our hardware should make this clear, let's take > an imaginary example of one port with 10 pins, one i2c interface, one > spi interface and one GPIO bank: > > | mux N-1| > ++ >

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-10 Thread Stephen Warren
On 07/08/2013 07:02 AM, Christian Ruppert wrote: ... OK, a small drawing of our hardware should make this clear, let's take an imaginary example of one port with 10 pins, one i2c interface, one spi interface and one GPIO bank: | mux N-1| ++

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-08 Thread Christian Ruppert
On Fri, Jul 05, 2013 at 12:40:55PM -0600, Stephen Warren wrote: > On 07/05/2013 03:49 AM, Christian Ruppert wrote: > > On Wed, Jun 26, 2013 at 11:40:42AM -0600, Stephen Warren wrote: > >> On 06/26/2013 05:50 AM, Christian Ruppert wrote: > >>> On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-08 Thread Christian Ruppert
On Fri, Jul 05, 2013 at 12:40:55PM -0600, Stephen Warren wrote: On 07/05/2013 03:49 AM, Christian Ruppert wrote: On Wed, Jun 26, 2013 at 11:40:42AM -0600, Stephen Warren wrote: On 06/26/2013 05:50 AM, Christian Ruppert wrote: On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote:

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-05 Thread Stephen Warren
On 07/05/2013 03:49 AM, Christian Ruppert wrote: > On Wed, Jun 26, 2013 at 11:40:42AM -0600, Stephen Warren wrote: >> On 06/26/2013 05:50 AM, Christian Ruppert wrote: >>> On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: On 06/18/2013 03:29 AM, Christian Ruppert wrote: >> [...]

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-05 Thread Christian Ruppert
On Wed, Jun 26, 2013 at 11:40:42AM -0600, Stephen Warren wrote: > On 06/26/2013 05:50 AM, Christian Ruppert wrote: > > On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: > >> On 06/18/2013 03:29 AM, Christian Ruppert wrote: > [...] > >>> +Example > >>> +--- > >>> + > >>> +iomux:

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-05 Thread Christian Ruppert
On Wed, Jun 26, 2013 at 11:40:42AM -0600, Stephen Warren wrote: On 06/26/2013 05:50 AM, Christian Ruppert wrote: On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: On 06/18/2013 03:29 AM, Christian Ruppert wrote: [...] +Example +--- + +iomux: iomux@FF10601c { +

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-07-05 Thread Stephen Warren
On 07/05/2013 03:49 AM, Christian Ruppert wrote: On Wed, Jun 26, 2013 at 11:40:42AM -0600, Stephen Warren wrote: On 06/26/2013 05:50 AM, Christian Ruppert wrote: On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: On 06/18/2013 03:29 AM, Christian Ruppert wrote: [...] +Example

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-26 Thread Stephen Warren
On 06/26/2013 05:50 AM, Christian Ruppert wrote: > On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: >> On 06/18/2013 03:29 AM, Christian Ruppert wrote: >>> The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. >>> Used to control the pinmux and is a

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-26 Thread Christian Ruppert
On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: > On 06/18/2013 03:29 AM, Christian Ruppert wrote: > > The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. > > Used to control the pinmux and is a prerequisite for the GPIO driver. > > > diff --git > >

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-26 Thread Christian Ruppert
On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: On 06/18/2013 03:29 AM, Christian Ruppert wrote: The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Used to control the pinmux and is a prerequisite for the GPIO driver. diff --git

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-26 Thread Stephen Warren
On 06/26/2013 05:50 AM, Christian Ruppert wrote: On Wed, Jun 19, 2013 at 04:35:14PM -0600, Stephen Warren wrote: On 06/18/2013 03:29 AM, Christian Ruppert wrote: The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Used to control the pinmux and is a prerequisite for

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-19 Thread Stephen Warren
On 06/18/2013 03:29 AM, Christian Ruppert wrote: > The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. > Used to control the pinmux and is a prerequisite for the GPIO driver. > diff --git a/Documentation/devicetree/bindings/pinctrl/abilis,tb10x-iomux.txt >

Re: [PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-19 Thread Stephen Warren
On 06/18/2013 03:29 AM, Christian Ruppert wrote: The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Used to control the pinmux and is a prerequisite for the GPIO driver. diff --git a/Documentation/devicetree/bindings/pinctrl/abilis,tb10x-iomux.txt

[PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-18 Thread Christian Ruppert
The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Used to control the pinmux and is a prerequisite for the GPIO driver. Signed-off-by: Christian Ruppert Signed-off-by: Pierrick Hascoet --- .../bindings/pinctrl/abilis,tb10x-iomux.txt| 81 ++

[PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-18 Thread Christian Ruppert
The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Used to control the pinmux and is a prerequisite for the GPIO driver. Signed-off-by: Christian Ruppert christian.rupp...@abilis.com Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com ---

[PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-17 Thread Christian Ruppert
The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Signed-off-by: Christian Ruppert Signed-off-by: Pierrick Hascoet --- .../bindings/pinctrl/abilis,tb10x-iomux.txt| 81 ++ drivers/pinctrl/Kconfig|4 + drivers/pinctrl/Makefile

[PATCH 2/4] pinmux: Add TB10x pinmux driver

2013-06-17 Thread Christian Ruppert
The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. Signed-off-by: Christian Ruppert christian.rupp...@abilis.com Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com --- .../bindings/pinctrl/abilis,tb10x-iomux.txt| 81 ++ drivers/pinctrl/Kconfig