Re: [PATCH 2/4] sched/fair: Do not replace recent_used_cpu with the new target

2020-12-08 Thread Mel Gorman
On Tue, Dec 08, 2020 at 10:57:29AM +0100, Dietmar Eggemann wrote: > On 07/12/2020 10:15, Mel Gorman wrote: > > After select_idle_sibling, p->recent_used_cpu is set to the > > new target. However on the next wakeup, prev will be the same as > > I'm confused here. Isn't current->recent_used_cpu set

Re: [PATCH 2/4] sched/fair: Do not replace recent_used_cpu with the new target

2020-12-08 Thread Dietmar Eggemann
On 07/12/2020 10:15, Mel Gorman wrote: > After select_idle_sibling, p->recent_used_cpu is set to the > new target. However on the next wakeup, prev will be the same as I'm confused here. Isn't current->recent_used_cpu set to 'cpu = smp_processor_id()' after sis()? Looking at v5.10-rc6. [...] >

[PATCH 2/4] sched/fair: Do not replace recent_used_cpu with the new target

2020-12-07 Thread Mel Gorman
After select_idle_sibling, p->recent_used_cpu is set to the new target. However on the next wakeup, prev will be the same as recent_used_cpu unless the load balancer has moved the task since the last wakeup. It still works, but is less efficient than it can be after all the changes that went in