Re: [PATCH 2/5] ARM: smp_scu: Add the enable speculative linefills operation

2014-06-30 Thread Gregory CLEMENT
Hi Thomas,>> + */ >> +void scu_spec_linefills_enable(void __iomem *scu_base, bool enable) >> +{ >> +u32 scu_ctrl; >> + >> +scu_ctrl = readl_relaxed(scu_base + SCU_CTRL); >> +/* already enabled? */ > > Comment not needed, since SCU_CTRL_ENABLE already documents what's > happening. Or a

Re: [PATCH 2/5] ARM: smp_scu: Add the enable speculative linefills operation

2014-06-30 Thread Gregory CLEMENT
Hi Thomas, + */ +void scu_spec_linefills_enable(void __iomem *scu_base, bool enable) +{ +u32 scu_ctrl; + +scu_ctrl = readl_relaxed(scu_base + SCU_CTRL); +/* already enabled? */ Comment not needed, since SCU_CTRL_ENABLE already documents what's happening. Or a more useful

Re: [PATCH 2/5] ARM: smp_scu: Add the enable speculative linefills operation

2014-06-28 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Fri, 27 Jun 2014 00:43:25 +0200, Gregory CLEMENT wrote: > Quotin the ARM datasheet "When set, coherent linefill requests are Quotin -> Quoting > sent speculatively to the L2C-310 in parallel with the tag look-up. If > the tag look-up misses, the confirmed linefill is

Re: [PATCH 2/5] ARM: smp_scu: Add the enable speculative linefills operation

2014-06-28 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Fri, 27 Jun 2014 00:43:25 +0200, Gregory CLEMENT wrote: Quotin the ARM datasheet When set, coherent linefill requests are Quotin - Quoting sent speculatively to the L2C-310 in parallel with the tag look-up. If the tag look-up misses, the confirmed linefill is sent to

[PATCH 2/5] ARM: smp_scu: Add the enable speculative linefills operation

2014-06-26 Thread Gregory CLEMENT
Quotin the ARM datasheet "When set, coherent linefill requests are sent speculatively to the L2C-310 in parallel with the tag look-up. If the tag look-up misses, the confirmed linefill is sent to the L2C-310 and gets RDATA earlier because the data request was already initiated by the speculative

[PATCH 2/5] ARM: smp_scu: Add the enable speculative linefills operation

2014-06-26 Thread Gregory CLEMENT
Quotin the ARM datasheet When set, coherent linefill requests are sent speculatively to the L2C-310 in parallel with the tag look-up. If the tag look-up misses, the confirmed linefill is sent to the L2C-310 and gets RDATA earlier because the data request was already initiated by the speculative