Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-07 Thread Viresh Kumar
On 7 June 2013 20:04, Lukasz Majewski wrote: > After refactoring the code. I admit, that we shall embed the struct > cpu_boost fields directly to the coufreq_driver. There is no point to > create structure with 2 fields. Great!! I will wait for your next version. -- To unsubscribe from this list:

Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-07 Thread Lukasz Majewski
Hi Viresh, > On 6 June 2013 17:19, Lukasz Majewski wrote: > >> On 6 June 2013 12:37, Lukasz Majewski > >> wrote: > > >> > cpufreq_driver->boost->attr)) > >> > >> Why is this required? Why do we want platforms to add some files > >> in sysfs? > > > > There are two kinds of attributes, which are

Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-07 Thread Lukasz Majewski
Hi Viresh, > Hi Lukasz, > > On 7 June 2013 18:57, Lukasz Majewski wrote: > > I hope you agreed to all the other comments I gave as I don't see an > explicit reply below each of these. I have seen people missing these > in past, so what would be better to do is: > - either reply below each one o

Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-07 Thread Viresh Kumar
Hi Lukasz, On 7 June 2013 18:57, Lukasz Majewski wrote: I hope you agreed to all the other comments I gave as I don't see an explicit reply below each of these. I have seen people missing these in past, so what would be better to do is: - either reply below each one of them and say yes or no.. -

Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-07 Thread Lukasz Majewski
Hi Viresh, > On 6 June 2013 17:19, Lukasz Majewski wrote: > >> On 6 June 2013 12:37, Lukasz Majewski > >> wrote: > > >> > cpufreq_driver->boost->attr)) > >> > >> Why is this required? Why do we want platforms to add some files > >> in sysfs? > > > > There are two kinds of attributes, which are

Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-06 Thread Viresh Kumar
On 6 June 2013 17:19, Lukasz Majewski wrote: >> On 6 June 2013 12:37, Lukasz Majewski wrote: >> > cpufreq_driver->boost->attr)) >> >> Why is this required? Why do we want platforms to add some files >> in sysfs? > > There are two kinds of attributes, which are exported by boost: > > 1. global bo

Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-06 Thread Lukasz Majewski
Hi Viresh, > Hi, > > On 6 June 2013 12:37, Lukasz Majewski wrote: > > This commit adds support for software based frequency boosting. > > Exynos4 SoCs (e.g. 4x12) allow setting of frequency above its normal > > condition limits. This can be done for some short time. > > > > Overclocking (boost)

Re: [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-06 Thread Viresh Kumar
Hi, On 6 June 2013 12:37, Lukasz Majewski wrote: > This commit adds support for software based frequency boosting. > Exynos4 SoCs (e.g. 4x12) allow setting of frequency above its normal > condition limits. This can be done for some short time. > > Overclocking (boost) support came from cpufreq dr

[PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost

2013-06-06 Thread Lukasz Majewski
This commit adds support for software based frequency boosting. Exynos4 SoCs (e.g. 4x12) allow setting of frequency above its normal condition limits. This can be done for some short time. Overclocking (boost) support came from cpufreq driver (which is platform dependent). Hence the data structure