Re: [PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path

2019-09-19 Thread Pavel Machek
On Tue 2019-09-17 19:19:55, Guido Günther wrote: > The driver currently reports successful initialization on every failure > as long as it's able to power off the regulator. Don't check the return > value of regulator_disable to avoid that. > > Signed-off-by: Guido Günther > --- >

Re: [PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path

2019-09-18 Thread Dan Murphy
Guido On 9/17/19 9:19 PM, Guido Günther wrote: The driver currently reports successful initialization on every failure as long as it's able to power off the regulator. Don't check the return value of regulator_disable to avoid that. Signed-off-by: Guido Günther ---

[PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path

2019-09-17 Thread Guido Günther
The driver currently reports successful initialization on every failure as long as it's able to power off the regulator. Don't check the return value of regulator_disable to avoid that. Signed-off-by: Guido Günther --- drivers/leds/leds-lm3692x.c | 9 +++-- 1 file changed, 3 insertions(+),