Re: [PATCH 2/5] perf script: extend db-export api to include callchains for samples

2016-04-28 Thread Chris Phlipot
Hi Adrian, I have just resubmitted these changes as a new patch set, which I believe should address most of your concerns. Please review the new patch set instead of continuing with this one. https://lkml.org/lkml/2016/4/28/75 Thanks, Chris On 04/22/2016 09:41 PM, Chris Phlipot wrote: On 04

Re: [PATCH 2/5] perf script: extend db-export api to include callchains for samples

2016-04-22 Thread Chris Phlipot
On 04/22/2016 12:56 AM, Adrian Hunter wrote: The call_paths table already has symbol_id which belongs uniquely to a DSO, so why do we need dso_id as well? If the symbol_id is 0 because the IP could not be resolved to a symbol, this is not necessarily a valid assumption. Without a dso_id in the

Re: [PATCH 2/5] perf script: extend db-export api to include callchains for samples

2016-04-22 Thread Adrian Hunter
On 19/04/16 11:56, Chris Phlipot wrote: > The current implementation of the python database export API only > includes call path information when using some form of call/return > tracing, but is unable to do so when sampling. > > The following API extensions allow exporting of data collected by >

[PATCH 2/5] perf script: extend db-export api to include callchains for samples

2016-04-19 Thread Chris Phlipot
The current implementation of the python database export API only includes call path information when using some form of call/return tracing, but is unable to do so when sampling. The following API extensions allow exporting of data collected by perf record when using --call-graph. The additions