Re: [PATCH 2/5] spi: mxs: cleanup wait_for_completion return handling

2015-02-02 Thread Mark Brown
On Mon, Feb 02, 2015 at 03:30:33AM -0500, Nicholas Mc Guire wrote: > - ret = wait_for_completion_timeout(>c, > - msecs_to_jiffies(SSP_TIMEOUT)); > - if (!ret) { > + if (!wait_for_completion_timeout(>c, > + msecs_to_jiffies(SSP_TIMEOUT))) { Your new

[PATCH 2/5] spi: mxs: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, this patch uses the return value of wait_for_completion_timeout in the condition directly rather than adding a additional appropriately typed variable. Signed-off-by: Nicholas Mc Guire --- The return type of

Re: [PATCH 2/5] spi: mxs: cleanup wait_for_completion return handling

2015-02-02 Thread Mark Brown
On Mon, Feb 02, 2015 at 03:30:33AM -0500, Nicholas Mc Guire wrote: - ret = wait_for_completion_timeout(spi-c, - msecs_to_jiffies(SSP_TIMEOUT)); - if (!ret) { + if (!wait_for_completion_timeout(spi-c, + msecs_to_jiffies(SSP_TIMEOUT))) { Your

[PATCH 2/5] spi: mxs: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, this patch uses the return value of wait_for_completion_timeout in the condition directly rather than adding a additional appropriately typed variable. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- The return type of