Re: [PATCH 2/6] genalloc: selftest

On 22/02/18 11:14, Igor Stoppa wrote: > > > On 22/02/18 00:28, Kees Cook wrote: >> On Tue, Feb 20, 2018 at 8:59 AM, Igor Stoppa wrote: >>> >>> >>> On 13/02/18 01:50, Kees Cook wrote: On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote:

Re: [PATCH 2/6] genalloc: selftest

On 22/02/18 11:14, Igor Stoppa wrote: > > > On 22/02/18 00:28, Kees Cook wrote: >> On Tue, Feb 20, 2018 at 8:59 AM, Igor Stoppa wrote: >>> >>> >>> On 13/02/18 01:50, Kees Cook wrote: On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > > [...] > > + genalloc_selftest();

Re: [PATCH 2/6] genalloc: selftest

On 22/02/18 00:28, Kees Cook wrote: > On Tue, Feb 20, 2018 at 8:59 AM, Igor Stoppa wrote: >> >> >> On 13/02/18 01:50, Kees Cook wrote: >>> On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: [...] + genalloc_selftest(); >>> >>> I

Re: [PATCH 2/6] genalloc: selftest

On 22/02/18 00:28, Kees Cook wrote: > On Tue, Feb 20, 2018 at 8:59 AM, Igor Stoppa wrote: >> >> >> On 13/02/18 01:50, Kees Cook wrote: >>> On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: [...] + genalloc_selftest(); >>> >>> I wonder if it's possible to make this

Re: [PATCH 2/6] genalloc: selftest

On Tue, Feb 20, 2018 at 8:59 AM, Igor Stoppa wrote: > > > On 13/02/18 01:50, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > > [...] > >>> lib/genalloc-selftest.c | 400 >>>

Re: [PATCH 2/6] genalloc: selftest

On Tue, Feb 20, 2018 at 8:59 AM, Igor Stoppa wrote: > > > On 13/02/18 01:50, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > > [...] > >>> lib/genalloc-selftest.c | 400 >>> ++ >> >> Nit: make this test_genalloc.c instead.

Re: [PATCH 2/6] genalloc: selftest

On 13/02/18 01:50, Kees Cook wrote: > On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: [...] >> lib/genalloc-selftest.c | 400 >> ++ > > Nit: make this test_genalloc.c instead. ok [...] >> +

Re: [PATCH 2/6] genalloc: selftest

On 13/02/18 01:50, Kees Cook wrote: > On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: [...] >> lib/genalloc-selftest.c | 400 >> ++ > > Nit: make this test_genalloc.c instead. ok [...] >> + genalloc_selftest(); > > I wonder if it's

Re: [PATCH 2/6] genalloc: selftest

On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > Introduce a set of macros for writing concise test cases for genalloc. > > The test cases are meant to provide regression testing, when working on > new functionality for genalloc. > > Primarily they are meant to

Re: [PATCH 2/6] genalloc: selftest

On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > Introduce a set of macros for writing concise test cases for genalloc. > > The test cases are meant to provide regression testing, when working on > new functionality for genalloc. > > Primarily they are meant to confirm that the various

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

Re: [PATCH 2/6] genalloc: selftest

On Sun, Feb 11, 2018 at 12:27:14PM -0800, Randy Dunlap wrote: > On 02/11/18 12:22, Philippe Ombredanne wrote: > > nit... For a comment in .h this line should be instead its own comment > > as the first line: > >> +/* SPDX-License-Identifier: GPL-2.0 */ > > Why are we treating header files (.h)

Re: [PATCH 2/6] genalloc: selftest

On Sun, Feb 11, 2018 at 12:27:14PM -0800, Randy Dunlap wrote: > On 02/11/18 12:22, Philippe Ombredanne wrote: > > nit... For a comment in .h this line should be instead its own comment > > as the first line: > >> +/* SPDX-License-Identifier: GPL-2.0 */ > > Why are we treating header files (.h)

Re: [PATCH 2/6] genalloc: selftest

On 02/11/18 12:22, Philippe Ombredanne wrote: > On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: >> Introduce a set of macros for writing concise test cases for genalloc. >> >> The test cases are meant to provide regression testing, when working on >> new functionality

Re: [PATCH 2/6] genalloc: selftest

On 02/11/18 12:22, Philippe Ombredanne wrote: > On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: >> Introduce a set of macros for writing concise test cases for genalloc. >> >> The test cases are meant to provide regression testing, when working on >> new functionality for genalloc. >> >>

Re: [PATCH 2/6] genalloc: selftest

On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: > Introduce a set of macros for writing concise test cases for genalloc. > > The test cases are meant to provide regression testing, when working on > new functionality for genalloc. > > Primarily they are meant to

Re: [PATCH 2/6] genalloc: selftest

On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: > Introduce a set of macros for writing concise test cases for genalloc. > > The test cases are meant to provide regression testing, when working on > new functionality for genalloc. > > Primarily they are meant to confirm that the various

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

Re: [PATCH 2/6] genalloc: selftest

On 07/02/18 22:25, kbuild test robot wrote: [...] >>> lib/genalloc-selftest.c:17:10: fatal error: asm/set_memory.h: No such file >>> or directory > #include This header is unnecessary and will be removed. -- igor

Re: [PATCH 2/6] genalloc: selftest

On 07/02/18 22:25, kbuild test robot wrote: [...] >>> lib/genalloc-selftest.c:17:10: fatal error: asm/set_memory.h: No such file >>> or directory > #include This header is unnecessary and will be removed. -- igor

Re: [PATCH 2/6] genalloc: selftest

On 05/02/18 00:19, Randy Dunlap wrote: > On 02/04/2018 08:47 AM, Igor Stoppa wrote: [...] > Please use kernel multi-line comment style. ok for all of them [...] >> +BUG_ON(!locations[action->location]); >> +print_first_chunk_bitmap(pool); >> +BUG_ON(compare_bitmaps(pool,

Re: [PATCH 2/6] genalloc: selftest

On 05/02/18 00:19, Randy Dunlap wrote: > On 02/04/2018 08:47 AM, Igor Stoppa wrote: [...] > Please use kernel multi-line comment style. ok for all of them [...] >> +BUG_ON(!locations[action->location]); >> +print_first_chunk_bitmap(pool); >> +BUG_ON(compare_bitmaps(pool,

Re: [PATCH 2/6] genalloc: selftest

On 05/02/18 02:14, Randy Dunlap wrote: > On 02/04/2018 03:03 PM, Matthew Wilcox wrote: >> On Sun, Feb 04, 2018 at 02:19:22PM -0800, Randy Dunlap wrote: +#ifndef __GENALLOC_SELFTEST_H__ +#define __GENALLOC_SELFTEST_H__ >>> >>> Please use _LINUX_GENALLOC_SELFTEST_H_ >> >>

Re: [PATCH 2/6] genalloc: selftest

On 05/02/18 02:14, Randy Dunlap wrote: > On 02/04/2018 03:03 PM, Matthew Wilcox wrote: >> On Sun, Feb 04, 2018 at 02:19:22PM -0800, Randy Dunlap wrote: +#ifndef __GENALLOC_SELFTEST_H__ +#define __GENALLOC_SELFTEST_H__ >>> >>> Please use _LINUX_GENALLOC_SELFTEST_H_ >> >>

Re: [PATCH 2/6] genalloc: selftest

Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on kees/for-next/pstore] [also build test ERROR on v4.15 next-20180207] [cannot apply to linus/master mmotm/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH 2/6] genalloc: selftest

Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on kees/for-next/pstore] [also build test ERROR on v4.15 next-20180207] [cannot apply to linus/master mmotm/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH 2/6] genalloc: selftest

On 02/04/2018 03:03 PM, Matthew Wilcox wrote: > On Sun, Feb 04, 2018 at 02:19:22PM -0800, Randy Dunlap wrote: >>> +#ifndef __GENALLOC_SELFTEST_H__ >>> +#define __GENALLOC_SELFTEST_H__ >> >> Please use _LINUX_GENALLOC_SELFTEST_H_ > > willy@bobo:~/kernel/linux$ git grep define.*_H__$

Re: [PATCH 2/6] genalloc: selftest

On 02/04/2018 03:03 PM, Matthew Wilcox wrote: > On Sun, Feb 04, 2018 at 02:19:22PM -0800, Randy Dunlap wrote: >>> +#ifndef __GENALLOC_SELFTEST_H__ >>> +#define __GENALLOC_SELFTEST_H__ >> >> Please use _LINUX_GENALLOC_SELFTEST_H_ > > willy@bobo:~/kernel/linux$ git grep define.*_H__$

Re: [PATCH 2/6] genalloc: selftest

On Sun, Feb 04, 2018 at 02:19:22PM -0800, Randy Dunlap wrote: > > +#ifndef __GENALLOC_SELFTEST_H__ > > +#define __GENALLOC_SELFTEST_H__ > > Please use _LINUX_GENALLOC_SELFTEST_H_ willy@bobo:~/kernel/linux$ git grep define.*_H__$ include/linux/*.h |wc -l 98 willy@bobo:~/kernel/linux$ git grep

Re: [PATCH 2/6] genalloc: selftest

On Sun, Feb 04, 2018 at 02:19:22PM -0800, Randy Dunlap wrote: > > +#ifndef __GENALLOC_SELFTEST_H__ > > +#define __GENALLOC_SELFTEST_H__ > > Please use _LINUX_GENALLOC_SELFTEST_H_ willy@bobo:~/kernel/linux$ git grep define.*_H__$ include/linux/*.h |wc -l 98 willy@bobo:~/kernel/linux$ git grep

Re: [PATCH 2/6] genalloc: selftest

On 02/04/2018 08:47 AM, Igor Stoppa wrote: > Introduce a set of macros for writing concise test cases for genalloc. > > The test cases are meant to provide regression testing, when working on > new functionality for genalloc. > > Primarily they are meant to confirm that the various allocation

Re: [PATCH 2/6] genalloc: selftest

On 02/04/2018 08:47 AM, Igor Stoppa wrote: > Introduce a set of macros for writing concise test cases for genalloc. > > The test cases are meant to provide regression testing, when working on > new functionality for genalloc. > > Primarily they are meant to confirm that the various allocation

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The

[PATCH 2/6] genalloc: selftest

Introduce a set of macros for writing concise test cases for genalloc. The test cases are meant to provide regression testing, when working on new functionality for genalloc. Primarily they are meant to confirm that the various allocation strategy will continue to work as expected. The