Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-26 Thread Toshi Kani
On Tue, 2013-03-26 at 13:22 +0100, Rafael J. Wysocki wrote: > On Monday, March 25, 2013 04:57:11 PM Toshi Kani wrote: > > On Mon, 2013-03-25 at 23:29 +0100, Rafael J. Wysocki wrote: > > > On Monday, March 25, 2013 02:45:36 PM Toshi Kani wrote: > > > > On Fri, 2013-03-15 at 11:47 +0100, Vasilis Lias

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-26 Thread Rafael J. Wysocki
On Monday, March 25, 2013 04:57:11 PM Toshi Kani wrote: > On Mon, 2013-03-25 at 23:29 +0100, Rafael J. Wysocki wrote: > > On Monday, March 25, 2013 02:45:36 PM Toshi Kani wrote: > > > On Fri, 2013-03-15 at 11:47 +0100, Vasilis Liaskovitis wrote: > > > > Hi, > > > > > > > > On Thu, Mar 14, 2013 at

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-25 Thread Toshi Kani
On Mon, 2013-03-25 at 23:29 +0100, Rafael J. Wysocki wrote: > On Monday, March 25, 2013 02:45:36 PM Toshi Kani wrote: > > On Fri, 2013-03-15 at 11:47 +0100, Vasilis Liaskovitis wrote: > > > Hi, > > > > > > On Thu, Mar 14, 2013 at 06:16:30PM +0100, Rafael J. Wysocki wrote: > > > > Sorry for the slu

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-25 Thread Rafael J. Wysocki
On Monday, March 25, 2013 02:45:36 PM Toshi Kani wrote: > On Fri, 2013-03-15 at 11:47 +0100, Vasilis Liaskovitis wrote: > > Hi, > > > > On Thu, Mar 14, 2013 at 06:16:30PM +0100, Rafael J. Wysocki wrote: > > > Sorry for the sluggish response, I've been travelling recently. -> > > [...] > > > > > >

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-25 Thread Toshi Kani
On Fri, 2013-03-15 at 11:47 +0100, Vasilis Liaskovitis wrote: > Hi, > > On Thu, Mar 14, 2013 at 06:16:30PM +0100, Rafael J. Wysocki wrote: > > Sorry for the sluggish response, I've been travelling recently. -> > [...] > > > > > So, I'd suggest the following changes. > > > > > - Remove the "uevent

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-15 Thread Vasilis Liaskovitis
Hi, On Thu, Mar 14, 2013 at 06:16:30PM +0100, Rafael J. Wysocki wrote: > Sorry for the sluggish response, I've been travelling recently. -> [...] > > > > So, I'd suggest the following changes. > > > > - Remove the "uevents" attribute. KOBJ_ONLINE/OFFLINE are not used for > > > > ACPI device obje

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-14 Thread Rafael J. Wysocki
Sorry for the sluggish response, I've been travelling recently. -> On Monday, March 04, 2013 02:10:23 PM Vasilis Liaskovitis wrote: > Hi, > > On Tue, Feb 26, 2013 at 12:39:50AM +0100, Rafael J. Wysocki wrote: > > On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: > > > On Sat, 2013-02-23

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-03-04 Thread Vasilis Liaskovitis
Hi, On Tue, Feb 26, 2013 at 12:39:50AM +0100, Rafael J. Wysocki wrote: > On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: > > On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Multiple drivers handling hotplug-capable ACPI device node

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Rafael J. Wysocki
On Tuesday, February 26, 2013 12:40:22 PM Yasuaki Ishimatsu wrote: > 2013/02/26 12:11, Rafael J. Wysocki wrote: > > On Tuesday, February 26, 2013 11:02:56 AM Yasuaki Ishimatsu wrote: > >> 2013/02/26 10:09, Toshi Kani wrote: > >>> On Tue, 2013-02-26 at 09:40 +0900, Yasuaki Ishimatsu wrote: > 20

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Yasuaki Ishimatsu
2013/02/26 12:11, Rafael J. Wysocki wrote: On Tuesday, February 26, 2013 11:02:56 AM Yasuaki Ishimatsu wrote: 2013/02/26 10:09, Toshi Kani wrote: On Tue, 2013-02-26 at 09:40 +0900, Yasuaki Ishimatsu wrote: 2013/02/26 8:39, Rafael J. Wysocki wrote: On Monday, February 25, 2013 11:07:52 AM Tosh

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Rafael J. Wysocki
On Tuesday, February 26, 2013 11:02:56 AM Yasuaki Ishimatsu wrote: > 2013/02/26 10:09, Toshi Kani wrote: > > On Tue, 2013-02-26 at 09:40 +0900, Yasuaki Ishimatsu wrote: > >> 2013/02/26 8:39, Rafael J. Wysocki wrote: > >>> On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: > On Sat, 201

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Yasuaki Ishimatsu
2013/02/26 10:09, Toshi Kani wrote: On Tue, 2013-02-26 at 09:40 +0900, Yasuaki Ishimatsu wrote: 2013/02/26 8:39, Rafael J. Wysocki wrote: On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Multiple d

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Toshi Kani
On Tue, 2013-02-26 at 09:40 +0900, Yasuaki Ishimatsu wrote: > 2013/02/26 8:39, Rafael J. Wysocki wrote: > > On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: > >> On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: > >>> From: Rafael J. Wysocki > >>> > >>> Multiple drivers handlin

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Yasuaki Ishimatsu
2013/02/26 8:39, Rafael J. Wysocki wrote: On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Toshi Kani
On Tue, 2013-02-26 at 00:39 +0100, Rafael J. Wysocki wrote: > On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: > > On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Multiple drivers handling hotplug-capable ACPI device nodes install >

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Rafael J. Wysocki
On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: > On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Multiple drivers handling hotplug-capable ACPI device nodes install > > notify handlers covering the same types of events in a very similar

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Toshi Kani
On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Multiple drivers handling hotplug-capable ACPI device nodes install > notify handlers covering the same types of events in a very similar > way. Moreover, those handlers are installed in separate namespace

[Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar way. Moreover, those handlers are installed in separate namespace walks, although that really should be done during namespace scans carr

Re: [Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-22 Thread Rafael J. Wysocki
On Friday, February 22, 2013 08:54:14 AM Toshi Kani wrote: > On Fri, 2013-02-22 at 13:37 +0100, Rafael J. Wysocki wrote: > > On Friday, February 22, 2013 05:51:28 PM Yasuaki Ishimatsu wrote: > > > 2013/02/22 10:50, Rafael J. Wysocki wrote: > > > > On Thursday, February 21, 2013 06:12:21 PM Toshi Ka

Re: [Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-22 Thread Toshi Kani
On Fri, 2013-02-22 at 13:37 +0100, Rafael J. Wysocki wrote: > On Friday, February 22, 2013 05:51:28 PM Yasuaki Ishimatsu wrote: > > 2013/02/22 10:50, Rafael J. Wysocki wrote: > > > On Thursday, February 21, 2013 06:12:21 PM Toshi Kani wrote: > > >> On Fri, 2013-02-22 at 00:06 +0100, Rafael J. Wysoc

Re: [Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-22 Thread Rafael J. Wysocki
On Friday, February 22, 2013 05:51:28 PM Yasuaki Ishimatsu wrote: > 2013/02/22 10:50, Rafael J. Wysocki wrote: > > On Thursday, February 21, 2013 06:12:21 PM Toshi Kani wrote: > >> On Fri, 2013-02-22 at 00:06 +0100, Rafael J. Wysocki wrote: > >>> From: Rafael J. Wysocki > >>> > >>> Multiple driver

Re: [Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-22 Thread Yasuaki Ishimatsu
2013/02/22 10:50, Rafael J. Wysocki wrote: On Thursday, February 21, 2013 06:12:21 PM Toshi Kani wrote: On Fri, 2013-02-22 at 00:06 +0100, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same typ

Re: [Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-21 Thread Rafael J. Wysocki
On Thursday, February 21, 2013 06:12:21 PM Toshi Kani wrote: > On Fri, 2013-02-22 at 00:06 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Multiple drivers handling hotplug-capable ACPI device nodes install > > notify handlers covering the same types of events in a very simila

Re: [Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-21 Thread Toshi Kani
On Fri, 2013-02-22 at 00:06 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Multiple drivers handling hotplug-capable ACPI device nodes install > notify handlers covering the same types of events in a very similar > way. Moreover, those handlers are installed in separate namespace

[Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar way. Moreover, those handlers are installed in separate namespace walks, although that really should be done during namespace scans carr

Re: [Update 2][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-21 Thread Rafael J. Wysocki
On Thursday, February 21, 2013 10:39:40 AM Toshi Kani wrote: > On Thu, 2013-02-21 at 16:52 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > : > > > > This update fixes an issue pointed out by Toshi Kani (_OST shouldn't be > > evaluated after successful _EJ0). > > > > Thanks, > > Ra

Re: [Update 2][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-21 Thread Toshi Kani
On Thu, 2013-02-21 at 16:52 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki : > > This update fixes an issue pointed out by Toshi Kani (_OST shouldn't be > evaluated after successful _EJ0). > > Thanks, > Rafael > > --- > drivers/acpi/scan.c | 272 >

[Update 2][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar way. Moreover, those handlers are installed in separate namespace walks, although that really should be done during namespace scans carr

Re: [Update][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-21 Thread Rafael J. Wysocki
On Wednesday, February 20, 2013 06:17:48 PM Toshi Kani wrote: > On Wed, 2013-02-20 at 23:49 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > : > > + > > +/** > > + * acpi_bus_hot_remove_device: hot-remove a device and its children > > + * @context: struct acpi_eject_event pointer (fr

Re: [Update][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-20 Thread Toshi Kani
On Wed, 2013-02-20 at 23:49 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki : > + > +/** > + * acpi_bus_hot_remove_device: hot-remove a device and its children > + * @context: struct acpi_eject_event pointer (freed in this func) > + * > + * Hot-remove a device and its children. This fun

[Update][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-20 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar way. Moreover, those handlers are installed in separate namespace walks, although that really should be done during namespace scans carr

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-20 Thread Rafael J. Wysocki
On Wednesday, February 20, 2013 01:23:34 PM Toshi Kani wrote: > On Wed, 2013-02-20 at 14:23 +0100, Rafael J. Wysocki wrote: > > On Tuesday, February 19, 2013 03:43:08 PM Yasuaki Ishimatsu wrote: > : > > > > > > > - status = acpi_os_hotplug_execute(acpi_bus_hot_remove_device, > > > > ej_eve

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-20 Thread Toshi Kani
On Wed, 2013-02-20 at 14:23 +0100, Rafael J. Wysocki wrote: > On Tuesday, February 19, 2013 03:43:08 PM Yasuaki Ishimatsu wrote: : > > > > > - status = acpi_os_hotplug_execute(acpi_bus_hot_remove_device, ej_event); > > > - if (ACPI_FAILURE(status)) { > > > - put_device(&acpi_device->dev);

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-20 Thread Rafael J. Wysocki
On Tuesday, February 19, 2013 04:10:15 PM Yasuaki Ishimatsu wrote: > 2013/02/19 15:43, Yasuaki Ishimatsu wrote: > > Hi Rafael, > > > > I have comments. Please see below. > > > > 2013/02/18 0:21, Rafael J. Wysocki wrote: > >> From: Rafael J. Wysocki > >> > >> Multiple drivers handling hotplug-capab

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-20 Thread Rafael J. Wysocki
On Tuesday, February 19, 2013 03:43:08 PM Yasuaki Ishimatsu wrote: > Hi Rafael, > > I have comments. Please see below. > > 2013/02/18 0:21, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Multiple drivers handling hotplug-capable ACPI device nodes install > > notify handlers coverin

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-18 Thread Yasuaki Ishimatsu
2013/02/19 15:43, Yasuaki Ishimatsu wrote: Hi Rafael, I have comments. Please see below. 2013/02/18 0:21, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar w

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-18 Thread Yasuaki Ishimatsu
Hi Rafael, I have comments. Please see below. 2013/02/18 0:21, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar way. Moreover, those handlers are installed

[PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar way. Moreover, those handlers are installed in separate namespace walks, although that really should be done during namespace scans carr