Re: [PATCH 2/7] uprobes: Don't return success if alloc_uprobe() fails

[Srikar Dronamraju]

* Oleg Nesterov  [2012-09-30 21:42:01]:

> If alloc_uprobe() fails uprobe_register() should return ENOMEM, not 0.
> 
> Signed-off-by: Oleg Nesterov 
> ---

Acked-by: Srikar Dronamraju 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/7] uprobes: Don't return success if alloc_uprobe() fails

[Srikar Dronamraju]

* Oleg Nesterov o...@redhat.com [2012-09-30 21:42:01]:

 If alloc_uprobe() fails uprobe_register() should return ENOMEM, not 0.
 
 Signed-off-by: Oleg Nesterov o...@redhat.com
 ---

Acked-by: Srikar Dronamraju sri...@linux.vnet.ibm.com

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/7] uprobes: Don't return success if alloc_uprobe() fails

[Oleg Nesterov]

If alloc_uprobe() fails uprobe_register() should return ENOMEM, not 0.

Signed-off-by: Oleg Nesterov 
---
 kernel/events/uprobes.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index a741ba7..3ec114c 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -813,7 +813,9 @@ int uprobe_register(struct inode *inode, loff_t offset, 
struct uprobe_consumer *
mutex_lock(uprobes_hash(inode));
uprobe = alloc_uprobe(inode, offset);
 
-   if (uprobe && !consumer_add(uprobe, uc)) {
+   if (!uprobe) {
+   ret = -ENOMEM;
+   } else if (!consumer_add(uprobe, uc)) {
ret = __uprobe_register(uprobe);
if (ret) {
uprobe->consumers = NULL;
-- 
1.5.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/7] uprobes: Don't return success if alloc_uprobe() fails

[Oleg Nesterov]

If alloc_uprobe() fails uprobe_register() should return ENOMEM, not 0.

Signed-off-by: Oleg Nesterov o...@redhat.com
---
 kernel/events/uprobes.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index a741ba7..3ec114c 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -813,7 +813,9 @@ int uprobe_register(struct inode *inode, loff_t offset, 
struct uprobe_consumer *
mutex_lock(uprobes_hash(inode));
uprobe = alloc_uprobe(inode, offset);
 
-   if (uprobe  !consumer_add(uprobe, uc)) {
+   if (!uprobe) {
+   ret = -ENOMEM;
+   } else if (!consumer_add(uprobe, uc)) {
ret = __uprobe_register(uprobe);
if (ret) {
uprobe-consumers = NULL;
-- 
1.5.5.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/