Re: [PATCH 2/8] kbuild: Support for Symbols.list creation

2017-09-04 Thread Joao Moreira
On 08/31/2017 12:24 PM, Joe Lawrence wrote: Hi Joao, Hi Joe and Josh, Thanks for the quick feedback, I'll be looking forward for your comments once you have the change to dig deeper :). I'll apply all typo-fixes, add klpclean to the PHONY targets and change the quiet_cmd invocation as

Re: [PATCH 2/8] kbuild: Support for Symbols.list creation

2017-09-04 Thread Joao Moreira
On 08/31/2017 12:24 PM, Joe Lawrence wrote: Hi Joao, Hi Joe and Josh, Thanks for the quick feedback, I'll be looking forward for your comments once you have the change to dig deeper :). I'll apply all typo-fixes, add klpclean to the PHONY targets and change the quiet_cmd invocation as

Re: [PATCH 2/8] kbuild: Support for Symbols.list creation

2017-08-31 Thread Josh Poimboeuf
On Thu, Aug 31, 2017 at 11:24:39AM -0400, Joe Lawrence wrote: > > +quiet_cmd_klp_map = LIVEPATCH Symbols.list > > nit: I don't think any other quiet_cmd invocations put a tab between the > label and file list. That said, "LIVEPATCH" is > 8 chars, so it's not > going to line up anyway.

Re: [PATCH 2/8] kbuild: Support for Symbols.list creation

2017-08-31 Thread Josh Poimboeuf
On Thu, Aug 31, 2017 at 11:24:39AM -0400, Joe Lawrence wrote: > > +quiet_cmd_klp_map = LIVEPATCH Symbols.list > > nit: I don't think any other quiet_cmd invocations put a tab between the > label and file list. That said, "LIVEPATCH" is > 8 chars, so it's not > going to line up anyway.

Re: [PATCH 2/8] kbuild: Support for Symbols.list creation

2017-08-31 Thread Joe Lawrence
Hi Joao, A few nitpicks in-line below... On Tue, Aug 29, 2017 at 04:01:34PM -0300, Joao Moreira wrote: > For automatic resolution of livepatch relocations, a file called > Symbols.list is used. This file maps symbols within every compiled > kernel object allowing the identification of symbols

Re: [PATCH 2/8] kbuild: Support for Symbols.list creation

2017-08-31 Thread Joe Lawrence
Hi Joao, A few nitpicks in-line below... On Tue, Aug 29, 2017 at 04:01:34PM -0300, Joao Moreira wrote: > For automatic resolution of livepatch relocations, a file called > Symbols.list is used. This file maps symbols within every compiled > kernel object allowing the identification of symbols

[PATCH 2/8] kbuild: Support for Symbols.list creation

2017-08-29 Thread Joao Moreira
For automatic resolution of livepatch relocations, a file called Symbols.list is used. This file maps symbols within every compiled kernel object allowing the identification of symbols whose name is unique, thus relocation can be automatically inferred, or providing information that helps

[PATCH 2/8] kbuild: Support for Symbols.list creation

2017-08-29 Thread Joao Moreira
For automatic resolution of livepatch relocations, a file called Symbols.list is used. This file maps symbols within every compiled kernel object allowing the identification of symbols whose name is unique, thus relocation can be automatically inferred, or providing information that helps