RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

2015-05-06 Thread Alan Stern
On Wed, 6 May 2015, Ramneek Mehresh wrote: > > The fields in the override structure are meant for convenience. The > > extra_priv_size field is the most important one; the other two fields (reset > > and port_power) are present only because so many drivers need them. > > > > There's no reason to

RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

2015-05-06 Thread Ramneek Mehresh
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Wednesday, May 06, 2015 7:49 PM > To: Mehresh Ramneek-B31383 > Cc: Kernel development list; Felipe Balbi; USB list; > gre...@linuxfoundation.org > Subject: RE: [PATCH 2/9][v3]usb:fs

RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

2015-05-06 Thread Alan Stern
On Wed, 6 May 2015, Ramneek Mehresh wrote: > > Also, I'm not going to let you add new fields into the ehci_driver_overrides > > structure. If you really need to override other routines, copy the approach > > used by ehci-tegra.c. > > > Understood...but I would appreciate if you could please expl

RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

2015-05-05 Thread Ramneek Mehresh
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Wednesday, May 06, 2015 1:00 AM > To: Mehresh Ramneek-B31383 > Cc: Kernel development list; Felipe Balbi; USB list; > gre...@linuxfoundation.org > Subject: Re: [PATCH 2/9][v3]usb:fs

Re: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

2015-05-05 Thread Alan Stern
On Tue, 5 May 2015, Ramneek Mehresh wrote: > Add workqueue to add/remove host driver (outside interrupt context) > upon each id change > > Signed-off-by: Ramneek Mehresh > --- > Changes for v3: > - use overrides for ehci_fsl_overrides > - remove struct ehci_hcd from ehci_fsl >

[PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

2015-05-05 Thread Ramneek Mehresh
Add workqueue to add/remove host driver (outside interrupt context) upon each id change Signed-off-by: Ramneek Mehresh --- Changes for v3: - use overrides for ehci_fsl_overrides - remove struct ehci_hcd from ehci_fsl - move ehci_fsl to ehci-fsl.h drivers/usb/host/ehci-f

[PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

2015-05-05 Thread Ramneek Mehresh
Add workqueue to add/remove host driver (outside interrupt context) upon each id change Signed-off-by: Ramneek Mehresh --- Changes for v3: - use overrides for ehci_fsl_overrides - remove struct ehci_hcd from ehci_fsl - move ehci_fsl to ehci-fsl.h drivers/usb/host/ehci-f