Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-24 Thread Paul E. McKenney
On Wed, Jun 24, 2020 at 09:52:49AM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 02:44:33PM -0700, Paul E. McKenney wrote: > > On Tue, Jun 23, 2020 at 10:46:46PM +0200, Peter Zijlstra wrote: > > > On Fri, Jun 19, 2020 at 03:15:55PM -0700, Paul E. McKenney wrote: > > > > > > > Just

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-24 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 02:44:33PM -0700, Paul E. McKenney wrote: > On Tue, Jun 23, 2020 at 10:46:46PM +0200, Peter Zijlstra wrote: > > On Fri, Jun 19, 2020 at 03:15:55PM -0700, Paul E. McKenney wrote: > > > > > Just following up because I don't see this anywhere. If I am supposed > > > to take

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-23 Thread Paul E. McKenney
On Tue, Jun 23, 2020 at 10:46:46PM +0200, Peter Zijlstra wrote: > On Fri, Jun 19, 2020 at 03:15:55PM -0700, Paul E. McKenney wrote: > > > Just following up because I don't see this anywhere. If I am supposed > > to take this (which is more plausible now that v5.8-rc1 is out), please > > let me

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-23 Thread Peter Zijlstra
On Fri, Jun 19, 2020 at 03:15:55PM -0700, Paul E. McKenney wrote: > Just following up because I don't see this anywhere. If I am supposed > to take this (which is more plausible now that v5.8-rc1 is out), please > let me know. Sorry, I got distracted by that NULL ptr thing, but that seems

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-19 Thread Paul E. McKenney
On Mon, Jun 15, 2020 at 10:14:04AM -0700, Paul E. McKenney wrote: > On Mon, Jun 15, 2020 at 06:24:27PM +0200, Peter Zijlstra wrote: > > On Mon, Jun 15, 2020 at 05:55:13PM +0200, Peter Zijlstra wrote: > > > On Mon, Jun 15, 2020 at 05:49:05PM +0200, Peter Zijlstra wrote: > > > > @@ -983,13 +993,17

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Paul E. McKenney
On Mon, Jun 15, 2020 at 10:14:04AM -0700, Paul E. McKenney wrote: > On Mon, Jun 15, 2020 at 06:24:27PM +0200, Peter Zijlstra wrote: > > On Mon, Jun 15, 2020 at 05:55:13PM +0200, Peter Zijlstra wrote: > > > On Mon, Jun 15, 2020 at 05:49:05PM +0200, Peter Zijlstra wrote: > > > > @@ -983,13 +993,17

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Paul E. McKenney
On Mon, Jun 15, 2020 at 08:33:25PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 10:14:04AM -0700, Paul E. McKenney wrote: > > > This merge window has been quite the trainwreck, hasn't it? :-/ > > Keeps life interesting I suppose.. ;-) ;-) ;-)

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 10:14:04AM -0700, Paul E. McKenney wrote: > This merge window has been quite the trainwreck, hasn't it? :-/ Keeps life interesting I suppose..

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Paul E. McKenney
On Mon, Jun 15, 2020 at 06:24:27PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 05:55:13PM +0200, Peter Zijlstra wrote: > > On Mon, Jun 15, 2020 at 05:49:05PM +0200, Peter Zijlstra wrote: > > > @@ -983,13 +993,17 @@ noinstr void rcu_nmi_enter(void) > > > if (!in_nmi()) > > >

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 05:55:13PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 05:49:05PM +0200, Peter Zijlstra wrote: > > @@ -983,13 +993,17 @@ noinstr void rcu_nmi_enter(void) > > if (!in_nmi()) > > rcu_cleanup_after_idle(); > > > > +

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 08:52:20AM -0700, Paul E. McKenney wrote: > On Mon, Jun 15, 2020 at 05:30:52PM +0200, Peter Zijlstra wrote: > > What shall we do with this patch? > > I plan to submit it to the v5.9 merge window. Do you need it to get > to mainline earlier? Yeah, we need it this round,

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 05:49:05PM +0200, Peter Zijlstra wrote: > @@ -983,13 +993,17 @@ noinstr void rcu_nmi_enter(void) > if (!in_nmi()) > rcu_cleanup_after_idle(); > > + instrumentation_begin(); > + // instrumentation for the noinstr

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Paul E. McKenney
On Mon, Jun 15, 2020 at 05:30:52PM +0200, Peter Zijlstra wrote: > On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > > > // RCU is now watching. Better not be in an extended quiescent state! > > > rcu_dynticks_task_trace_exit(); // After ->dynticks update! > > >

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Peter Zijlstra
On Wed, Jun 03, 2020 at 01:40:16PM +0200, Peter Zijlstra wrote: > A KCSAN build revealed we have explicit annoations through atomic_*() > usage, switch to arch_atomic_*() for the respective functions. > > vmlinux.o: warning: objtool: rcu_nmi_exit()+0x4d: call to > __kcsan_check_access() leaves

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Peter Zijlstra
On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > // RCU is now watching. Better not be in an extended quiescent state! > > rcu_dynticks_task_trace_exit(); // After ->dynticks update! > > WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && > > !(seq

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-04 Thread Paul E. McKenney
On Thu, Jun 04, 2020 at 10:05:12AM +0200, Peter Zijlstra wrote: > On Wed, Jun 03, 2020 at 08:34:09PM -0700, Paul E. McKenney wrote: > > On Wed, Jun 03, 2020 at 07:13:20PM +0200, Peter Zijlstra wrote: > > > On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > > > > > @@ -313,7

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-04 Thread Paul E. McKenney
On Thu, Jun 04, 2020 at 08:02:31AM +0200, Marco Elver wrote: > On Thu, 4 Jun 2020 at 05:34, Paul E. McKenney wrote: > > > > On Wed, Jun 03, 2020 at 07:13:20PM +0200, Peter Zijlstra wrote: > > > On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > > > > > > > ---

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-04 Thread Peter Zijlstra
On Wed, Jun 03, 2020 at 08:34:09PM -0700, Paul E. McKenney wrote: > On Wed, Jun 03, 2020 at 07:13:20PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > > > @@ -313,7 +313,7 @@ static __always_inline bool rcu_dynticks > > > > { > > > >

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-04 Thread Marco Elver
On Thu, 4 Jun 2020 at 05:34, Paul E. McKenney wrote: > > On Wed, Jun 03, 2020 at 07:13:20PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > > > > > --- a/kernel/rcu/tree.c > > > > +++ b/kernel/rcu/tree.c > > > > @@ -250,7 +250,7 @@ static

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-03 Thread Paul E. McKenney
On Wed, Jun 03, 2020 at 07:13:20PM +0200, Peter Zijlstra wrote: > On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > > > --- a/kernel/rcu/tree.c > > > +++ b/kernel/rcu/tree.c > > > @@ -250,7 +250,7 @@ static noinstr void rcu_dynticks_eqs_ent > > >* next idle sojourn. > > >

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-03 Thread Peter Zijlstra
On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -250,7 +250,7 @@ static noinstr void rcu_dynticks_eqs_ent > > * next idle sojourn. > > */ > > rcu_dynticks_task_trace_enter(); // Before ->dynticks

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-03 Thread Paul E. McKenney
On Wed, Jun 03, 2020 at 01:40:16PM +0200, Peter Zijlstra wrote: > A KCSAN build revealed we have explicit annoations through atomic_*() > usage, switch to arch_atomic_*() for the respective functions. > > vmlinux.o: warning: objtool: rcu_nmi_exit()+0x4d: call to > __kcsan_check_access() leaves

[PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-03 Thread Peter Zijlstra
A KCSAN build revealed we have explicit annoations through atomic_*() usage, switch to arch_atomic_*() for the respective functions. vmlinux.o: warning: objtool: rcu_nmi_exit()+0x4d: call to __kcsan_check_access() leaves .noinstr.text section vmlinux.o: warning: objtool: