Re: [PATCH 20/20] cw1200: drop useless LIST_HEAD

[Kalle Valo]

Julia Lawall  wrote:

> Drop LIST_HEAD where the variable it declares has never
> been used.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // 
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // 
> 
> Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN 
> chipsets")
> Signed-off-by: Julia Lawall 

Patch applied to wireless-drivers-next.git, thanks.

06605b0d38b4 cw1200: drop useless LIST_HEAD

-- 
https://patchwork.kernel.org/patch/10741603/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 20/20] cw1200: drop useless LIST_HEAD

[Julia Lawall]

On Tue, 8 Jan 2019, Kalle Valo wrote:

> Julia Lawall  writes:
>
> > Drop LIST_HEAD where the variable it declares has never
> > been used.
> >
> > The semantic patch that fixes this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // 
> > @@
> > identifier x;
> > @@
> > - LIST_HEAD(x);
> >   ... when != x
> > // 
> >
> > Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN 
> > chipsets")
> > Signed-off-by: Julia Lawall 
> >
> > ---
> > Successfully 0-day tested on 151 configurations.
>
> I assume I can take this to wireless-drivers-next. If you are planning
> to push this via some other tree please let me know.

Please take it.  Thanks.

julia

Re: [PATCH 20/20] cw1200: drop useless LIST_HEAD

[Kalle Valo]

Julia Lawall  writes:

> Drop LIST_HEAD where the variable it declares has never
> been used.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // 
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // 
>
> Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN 
> chipsets")
> Signed-off-by: Julia Lawall 
>
> ---
> Successfully 0-day tested on 151 configurations.

I assume I can take this to wireless-drivers-next. If you are planning
to push this via some other tree please let me know.

-- 
Kalle Valo

[PATCH 20/20] cw1200: drop useless LIST_HEAD

[Julia Lawall]

Drop LIST_HEAD where the variable it declares has never
been used.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
identifier x;
@@
- LIST_HEAD(x);
  ... when != x
// 

Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN 
chipsets")
Signed-off-by: Julia Lawall 

---
Successfully 0-day tested on 151 configurations.

 drivers/net/wireless/st/cw1200/queue.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/st/cw1200/queue.c 
b/drivers/net/wireless/st/cw1200/queue.c
index 7c31b63b8258..7895efefa95d 100644
--- a/drivers/net/wireless/st/cw1200/queue.c
+++ b/drivers/net/wireless/st/cw1200/queue.c
@@ -283,7 +283,6 @@ int cw1200_queue_put(struct cw1200_queue *queue,
 struct cw1200_txpriv *txpriv)
 {
int ret = 0;
-   LIST_HEAD(gc_list);
struct cw1200_queue_stats *stats = queue->stats;
 
if (txpriv->link_id >= queue->stats->map_capacity)