Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-04 Thread Steven Rostedt
On Wed, 4 Dec 2013 10:29:32 -0300 Arnaldo Carvalho de Melo wrote: > Yeah, I also have some reservations about adding more globals (the > trace_event stuff just to associate a plugins list with pevent, probably > pevent should have that list, haven't looked 100% at the code), but in > general

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-04 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 04, 2013 at 10:29:34AM +0100, Jiri Olsa escreveu: > On Tue, Dec 03, 2013 at 11:16:01AM -0500, Steven Rostedt wrote: > > On Tue, 3 Dec 2013 14:09:36 +0100 Jiri Olsa wrote: > > > Removing malloc_or_die calls from event-plugin.c, > > > replacing them with standard malloc and error

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-04 Thread Jiri Olsa
On Tue, Dec 03, 2013 at 11:16:01AM -0500, Steven Rostedt wrote: > On Tue, 3 Dec 2013 14:09:36 +0100 > Jiri Olsa wrote: > > > Removing malloc_or_die calls from event-plugin.c, > > replacing them with standard malloc and error path. > > > > Suggested-by: Namhyung Kim > > Signed-off-by: Jiri

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-04 Thread Jiri Olsa
On Tue, Dec 03, 2013 at 11:16:01AM -0500, Steven Rostedt wrote: On Tue, 3 Dec 2013 14:09:36 +0100 Jiri Olsa jo...@redhat.com wrote: Removing malloc_or_die calls from event-plugin.c, replacing them with standard malloc and error path. Suggested-by: Namhyung Kim namhy...@kernel.org

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-04 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 04, 2013 at 10:29:34AM +0100, Jiri Olsa escreveu: On Tue, Dec 03, 2013 at 11:16:01AM -0500, Steven Rostedt wrote: On Tue, 3 Dec 2013 14:09:36 +0100 Jiri Olsa jo...@redhat.com wrote: Removing malloc_or_die calls from event-plugin.c, replacing them with standard malloc and

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-04 Thread Steven Rostedt
On Wed, 4 Dec 2013 10:29:32 -0300 Arnaldo Carvalho de Melo a...@ghostprotocols.net wrote: Yeah, I also have some reservations about adding more globals (the trace_event stuff just to associate a plugins list with pevent, probably pevent should have that list, haven't looked 100% at the code),

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-03 Thread Steven Rostedt
On Tue, 3 Dec 2013 14:09:36 +0100 Jiri Olsa wrote: > Removing malloc_or_die calls from event-plugin.c, > replacing them with standard malloc and error path. > > Suggested-by: Namhyung Kim > Signed-off-by: Jiri Olsa > Cc: Corey Ashford > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc:

[PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-03 Thread Jiri Olsa
Removing malloc_or_die calls from event-plugin.c, replacing them with standard malloc and error path. Suggested-by: Namhyung Kim Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arnaldo Carvalho

[PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-03 Thread Jiri Olsa
Removing malloc_or_die calls from event-plugin.c, replacing them with standard malloc and error path. Suggested-by: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-03 Thread Steven Rostedt
On Tue, 3 Dec 2013 14:09:36 +0100 Jiri Olsa jo...@redhat.com wrote: Removing malloc_or_die calls from event-plugin.c, replacing them with standard malloc and error path. Suggested-by: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford