On Wed, Jul 20, 2005 at 12:54:09PM -0500, Nathan Lynch wrote:
> Matt Domsch wrote:
> > On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
> > > On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
> > > > In general, this construct:
> > > >
> > > > > > -#if (LINUX_VERSION_CODE <
On 7/19/05, Moore, Eric Dean <[EMAIL PROTECTED]> wrote:
> On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
> > In general, this construct:
> >
> > > > -#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,6))
> > > > -static int inline scsi_device_online(struct scsi_device *sdev)
> > > > -{
> > > > -
Matt Domsch wrote:
> On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
> > On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
> > > In general, this construct:
> > >
> > > > > -#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,6))
> > > > > -static int inline
On Tue, Jul 19, 2005 at 10:12:49PM -0500, Matt Domsch wrote:
> > What you illustrated above is not going to work.
> > If your doing #ifndef around a function, such as scsi_device_online, it's
> > not going to compile
> > when scsi_device_online is already implemented in the kernel tree.
> > The
On Tue, 2005-07-19 at 22:12 -0500, Matt Domsch wrote:
> On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
[...]
> > What you illustrated above is not going to work.
> > If your doing #ifndef around a function, such as scsi_device_online, it's
> > not going to compile
> > when
On Tue, 2005-07-19 at 22:12 -0500, Matt Domsch wrote:
On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
[...]
What you illustrated above is not going to work.
If your doing #ifndef around a function, such as scsi_device_online, it's
not going to compile
when
On Tue, Jul 19, 2005 at 10:12:49PM -0500, Matt Domsch wrote:
What you illustrated above is not going to work.
If your doing #ifndef around a function, such as scsi_device_online, it's
not going to compile
when scsi_device_online is already implemented in the kernel tree.
The routine
Matt Domsch wrote:
On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
In general, this construct:
-#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))
-static int inline scsi_device_online(struct scsi_device
On 7/19/05, Moore, Eric Dean [EMAIL PROTECTED] wrote:
On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
In general, this construct:
-#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))
-static int inline scsi_device_online(struct scsi_device *sdev)
-{
- return sdev-online;
On Wed, Jul 20, 2005 at 12:54:09PM -0500, Nathan Lynch wrote:
Matt Domsch wrote:
On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
In general, this construct:
-#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))
On Tuesday, July 19, 2005 9:12 PM, Matt Domsch wrote:
What you illustrated above is not going to work.
If your doing #ifndef around a function, such as scsi_device_online, it's
not going to compile
when scsi_device_online is already implemented in the kernel tree.
The routine scsi_device_online
On Tue, 19 Jul 2005 22:12:49 -0500 Matt Domsch <[EMAIL PROTECTED]> wrote:
>
> Sure it does, function names are defined symbols.
>
> I'm doing exactly this in my backport of the openipmi drivers to RHEL4
> and SLES9.
I missed the smiley, right :-)
--
Cheers,
Stephen Rothwell
On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
> On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
> > In general, this construct:
> >
> > > > -#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,6))
> > > > -static int inline scsi_device_online(struct scsi_device *sdev)
> > > >
On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
> In general, this construct:
>
> > > -#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,6))
> > > -static int inline scsi_device_online(struct scsi_device *sdev)
> > > -{
> > > - return sdev->online;
> > > -}
> > > -#endif
>
> is better tested
On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
In general, this construct:
-#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))
-static int inline scsi_device_online(struct scsi_device *sdev)
-{
- return sdev-online;
-}
-#endif
is better tested as:
#ifndef
On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote:
On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote:
In general, this construct:
-#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))
-static int inline scsi_device_online(struct scsi_device *sdev)
-{
-
On Tue, 19 Jul 2005 22:12:49 -0500 Matt Domsch [EMAIL PROTECTED] wrote:
Sure it does, function names are defined symbols.
I'm doing exactly this in my backport of the openipmi drivers to RHEL4
and SLES9.
I missed the smiley, right :-)
--
Cheers,
Stephen Rothwell[EMAIL
On Tuesday, July 19, 2005 9:12 PM, Matt Domsch wrote:
What you illustrated above is not going to work.
If your doing #ifndef around a function, such as scsi_device_online, it's
not going to compile
when scsi_device_online is already implemented in the kernel tree.
The routine scsi_device_online
On Wednesday, July 13, 2005 8:38 AM, Christoph Hellwig wrote:
>
> > In general, this construct:
> >
> > > > -#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,6))
> > > > -static int inline scsi_device_online(struct scsi_device *sdev)
> > > > -{
> > > > - return sdev->online;
> > > > -}
> > > >
> In general, this construct:
>
> > > -#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,6))
> > > -static int inline scsi_device_online(struct scsi_device *sdev)
> > > -{
> > > - return sdev->online;
> > > -}
> > > -#endif
>
> is better tested as:
>
> #ifndef scsi_device_inline
> static int inline
In general, this construct:
-#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))
-static int inline scsi_device_online(struct scsi_device *sdev)
-{
- return sdev-online;
-}
-#endif
is better tested as:
#ifndef scsi_device_inline
static int inline scsi_device_online(struct
On Wednesday, July 13, 2005 8:38 AM, Christoph Hellwig wrote:
In general, this construct:
-#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))
-static int inline scsi_device_online(struct scsi_device *sdev)
-{
- return sdev-online;
-}
-#endif
is better tested
Eric, I have to have a similar compat file for the IPMI drivers
backported onto RHEL3, RHEL4, and SLES9. They aren't in mainline of
course, but each OS has a slightly different copy for its needs, so my
DKMS packages carry it.
In general, this construct:
> > -#if (LINUX_VERSION_CODE <
> > But Id rather have same files in our maintained driver,
> > and whats in the kernel tree.
>
> Just think what a mess we'd have on our hands if we let
> everyone do that. Sorry, please don't put compat header
> files into the current upstream tree, thanks.
>
Fine.
-
To unsubscribe from this
From: "Moore, Eric Dean" <[EMAIL PROTECTED]>
Date: Tue, 12 Jul 2005 14:50:19 -0600
> But Id rather have same files in our maintained driver,
> and whats in the kernel tree.
Just think what a mess we'd have on our hands if we let
everyone do that. Sorry, please don't put compat header
files into
>
> On Sun, 2005-07-10 at 18:15 -0600, Moore, Eric Dean wrote:
> > I'd rather you not kill linux_compat.h file.
> > I use this file for compatibility of driver source
> > across various kernel versions. I provide our
> > customers with driver builds containing single source
> > which needs to
On Tue, 2005-07-12 at 14:50 -0600, Moore, Eric Dean wrote:
> The 3.02.18 driver and the driver in kernel tree are totally different
> drivers.
> One thing is 3.02.18 has SAS support, and the kernel tree doesn't.Id
> wish
> kernel folks would take our SAS drivers.
Is there a patch that applies
On Sun, 2005-07-10 at 18:15 -0600, Moore, Eric Dean wrote:
> I'd rather you not kill linux_compat.h file.
> I use this file for compatibility of driver source
> across various kernel versions. I provide our
> customers with driver builds containing single source
> which needs to compile in
On Tue, 2005-07-12 at 14:50 -0600, Moore, Eric Dean wrote:
The 3.02.18 driver and the driver in kernel tree are totally different
drivers.
One thing is 3.02.18 has SAS support, and the kernel tree doesn't.Id
wish
kernel folks would take our SAS drivers.
Is there a patch that applies
On Sun, 2005-07-10 at 18:15 -0600, Moore, Eric Dean wrote:
I'd rather you not kill linux_compat.h file.
I use this file for compatibility of driver source
across various kernel versions. I provide our
customers with driver builds containing single source
which needs to compile in
From: Moore, Eric Dean [EMAIL PROTECTED]
Date: Tue, 12 Jul 2005 14:50:19 -0600
But Id rather have same files in our maintained driver,
and whats in the kernel tree.
Just think what a mess we'd have on our hands if we let
everyone do that. Sorry, please don't put compat header
files into the
But Id rather have same files in our maintained driver,
and whats in the kernel tree.
Just think what a mess we'd have on our hands if we let
everyone do that. Sorry, please don't put compat header
files into the current upstream tree, thanks.
Fine.
-
To unsubscribe from this list:
Eric, I have to have a similar compat file for the IPMI drivers
backported onto RHEL3, RHEL4, and SLES9. They aren't in mainline of
course, but each OS has a slightly different copy for its needs, so my
DKMS packages carry it.
In general, this construct:
-#if (LINUX_VERSION_CODE
On Sun, 2005-07-10 at 18:15 -0600, Moore, Eric Dean wrote:
I'd rather you not kill linux_compat.h file.
I use this file for compatibility of driver source
across various kernel versions. I provide our
customers with driver builds containing single source
which needs to compile in kernels
I'd rather you not kill linux_compat.h file.
I use this file for compatibility of driver source
across various kernel versions. I provide our
customers with driver builds containing single source
which needs to compile in kernels 2.6.5( e.g. SLES9),
2.6.8 (e.g. RHEL4), and 2.6.11 ( e.g. SuSE
I'd rather you not kill linux_compat.h file.
I use this file for compatibility of driver source
across various kernel versions. I provide our
customers with driver builds containing single source
which needs to compile in kernels 2.6.5( e.g. SLES9),
2.6.8 (e.g. RHEL4), and 2.6.11 ( e.g. SuSE
36 matches
Mail list logo
